From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA30FC43334 for ; Thu, 21 Jul 2022 21:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbiGUVcK (ORCPT ); Thu, 21 Jul 2022 17:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbiGUVcI (ORCPT ); Thu, 21 Jul 2022 17:32:08 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EFF39287E for ; Thu, 21 Jul 2022 14:32:07 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id g17so3016157plh.2 for ; Thu, 21 Jul 2022 14:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hwDcOu7LN9Dw2toWSOc35XI4MHXeLdUNl8u96Y2Tf38=; b=B3hZ855CTyXHAXlIhrn3uu9tf4LNKr3XEQYwUIfhZ2nMRJsUmL62z4eAMRqjhvNiQd NYa3ZVaeBkzeOfH+/hopGkGmnntsXMGEOSPzLS7bC7QpsvWh3lJ7AuZYW9d8TvBxZryT wYxixEj3M7Id5GaGecv2X0Nx0UQp9j6wM60Mx3cqBoFuMiVBC9WdSi5jlO/Tvj7zcdBY HbJoKZ7dNfajw08xttZpNME1QSyM8rrV04dQ5X3XASdZ7FOak2zGVrxHPb3y+G15Bzge 8lAmEq4Eyfk+DdOOThKX0/m+Is3tgn/hg/rxTDQFMkTOJb+BM7ADt+Q6/8/o3hlRo/C/ +PAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hwDcOu7LN9Dw2toWSOc35XI4MHXeLdUNl8u96Y2Tf38=; b=pRpxjUR5raRjdSbhmwkYnyHJ5j9w0dfHYmSkudeFqSz/h4VNDVuWlb0LY4dJVj+U6+ jm5EMt6tI4DNiu/PMFdank3l4mT+RG1e4x+qBpKguyH2/nGLo0DHhpwdeaUGk7/uLcUQ JuQhK7J08dlr8cqpJ4x+9novpJSCQ3JYOxgFnAsyrKlwrBPPPbiSRDGE4k/9AZn5rvC7 InhpbLoMogEPNCPgpFcEGpL89xDe/ROxPY8kxmii7peXUC6bsAwwi0Fi/9HLTeeJbN21 XYl1dqpqjh8lQhMJJ5Vp0HyMkAQMaGSCIGLrxOLO6a4SxgVBXvCjvZVXAwW0Potb+mKy kndg== X-Gm-Message-State: AJIora9KmMMOEvL9Ep0YaDcbaZ9bONU7N0YLx7oGRHIQ70eNZh4VdcLq O8sCVY8W2hVAJHsQdZP9LsL6mQ== X-Google-Smtp-Source: AGRyM1vaJbihXeme2HVwPKDEkXAC02RH9yfXYC/UoHS42V92vNQP8i1GvTakXThmP8OgRHqr5v8/OQ== X-Received: by 2002:a17:902:d395:b0:16b:e5e9:ac59 with SMTP id e21-20020a170902d39500b0016be5e9ac59mr281038pld.74.1658439126537; Thu, 21 Jul 2022 14:32:06 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id g3-20020a1709026b4300b0016c6e360ff6sm2131990plt.303.2022.07.21.14.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 14:32:06 -0700 (PDT) Date: Thu, 21 Jul 2022 21:32:02 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Siddharth Chandrasekaran , Yuan Yao , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 28/39] KVM: selftests: Fill in vm->vpages_mapped bitmap in virt_map() too Message-ID: References: <20220714134929.1125828-1-vkuznets@redhat.com> <20220714134929.1125828-29-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220714134929.1125828-29-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022, Vitaly Kuznetsov wrote: > Similar to vm_vaddr_alloc(), virt_map() needs to reflect the mapping > in vm->vpages_mapped. > > Signed-off-by: Vitaly Kuznetsov > --- > tools/testing/selftests/kvm/lib/kvm_util.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 768f3bce0161..63f411f7da1e 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -1275,6 +1275,9 @@ void virt_map(struct kvm_vm *vm, uint64_t vaddr, uint64_t paddr, > virt_pg_map(vm, vaddr, paddr); > vaddr += page_size; > paddr += page_size; > + > + sparsebit_set(vm->vpages_mapped, > + vaddr >> vm->page_shift); No need to wrap. Can you also fix vm_vaddr_alloc(), which I assume is the source of the copy+paste?