From: Mark Brown <broonie@kernel.org>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
Cc: alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com,
Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, ssabakar@amd.com,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Yang Yingliang <yangyingliang@huawei.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open
Date: Thu, 21 Jul 2022 23:23:15 +0100 [thread overview]
Message-ID: <YtnR05hxiWNKOGoC@sirena.org.uk> (raw)
In-Reply-To: <20220721062043.3016985-3-venkataprasad.potturu@amd.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On Thu, Jul 21, 2022 at 11:50:35AM +0530, Venkata Prasad Potturu wrote:
> From: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
>
> We are currently allocating acp_stream during pcm_open and saving
> it in static array corresponds to array index calculated based on
> cpu dai->driver id. This approach will fail if we have single dai
> linked to multiple pcm device as we will have same dai->driver id
> or array index for multiple pcm open. Initialize new linked list
> stream_list to store opened pcm stream info dynamically.
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/amd/acp/acp-platform.c: In function ‘i2s_irq_handler’:
/build/stage/linux/sound/soc/amd/acp/acp-platform.c:108:31: error: ‘struct acp_dev_data’ has no member named ‘stream’
108 | stream = adata->stream[i];
| ^~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/amd/acp/acp-platform.o] Error 1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-21 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 6:20 [PATCH 1/5] ASoC: amd: acp: Modify local variables name to generic Venkata Prasad Potturu
2022-07-21 6:20 ` [PATCH 2/5] ASoC: amd: acp: Drop superfluous mmap callback Venkata Prasad Potturu
2022-07-21 6:20 ` [PATCH 3/5] ASoC: amd: acp: Initialize list to store acp_stream during pcm_open Venkata Prasad Potturu
2022-07-21 22:23 ` Mark Brown [this message]
2022-07-21 6:20 ` [PATCH 4/5] ASoC: amd: acp: Modify const resource struct variable to generic Venkata Prasad Potturu
2022-07-21 6:20 ` [PATCH 5/5] ASoC: amd: acp: Add error handling cases Venkata Prasad Potturu
2022-07-22 12:48 ` [PATCH 1/5] ASoC: amd: acp: Modify local variables name to generic Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtnR05hxiWNKOGoC@sirena.org.uk \
--to=broonie@kernel.org \
--cc=AjitKumar.Pandey@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ssabakar@amd.com \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=vsujithkumar.reddy@amd.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®