From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tomer Maimon <tmaimon77@gmail.com>,
avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support
Date: Fri, 22 Jul 2022 19:43:23 +0100 [thread overview]
Message-ID: <YtrvyyMGm64hFG5j@sirena.org.uk> (raw)
In-Reply-To: <afae04e0-76a3-1bcb-5b47-9944fa9ab2c0@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Fri, Jul 22, 2022 at 08:31:22PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2022 13:41, Tomer Maimon wrote:
> > static const struct of_device_id npcm_pspi_match[] = {
> > { .compatible = "nuvoton,npcm750-pspi", .data = NULL },
> > + { .compatible = "nuvoton,npcm845-pspi", .data = NULL },
> The devices look compatible, so why not reusing 750 compatible and
> adding more specific upfront only in the bindings instead?
...with a fallback list required by the bindings so the driver actually
binds. Note that bindings are currently not in YAML format so there'd
be even less enforcement of that than normal, and as they're currently
written the bindings don't require fallback.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-22 18:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:41 [PATCH v2 0/2] spi: npcm-pspi: add Arbel NPCM8XX support Tomer Maimon
2022-07-22 11:41 ` [PATCH v2 1/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible Tomer Maimon
2022-07-25 22:56 ` Rob Herring
2022-07-26 9:30 ` Tomer Maimon
2022-07-26 9:57 ` Krzysztof Kozlowski
2022-07-22 11:41 ` [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support Tomer Maimon
2022-07-22 18:31 ` Krzysztof Kozlowski
2022-07-22 18:43 ` Mark Brown [this message]
2022-07-22 18:47 ` Krzysztof Kozlowski
2022-07-22 18:57 ` Mark Brown
2022-07-24 8:44 ` Tomer Maimon
2022-07-26 9:47 ` Krzysztof Kozlowski
2022-07-26 19:32 ` Tomer Maimon
2022-07-27 6:51 ` Krzysztof Kozlowski
2022-08-15 15:44 ` [PATCH v2 0/2] spi: npcm-pspi: add Arbel NPCM8XX support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtrvyyMGm64hFG5j@sirena.org.uk \
--to=broonie@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®