From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE02DC433EF for ; Sat, 23 Jul 2022 13:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235282AbiGWNnz (ORCPT ); Sat, 23 Jul 2022 09:43:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234852AbiGWNnw (ORCPT ); Sat, 23 Jul 2022 09:43:52 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2026641D for ; Sat, 23 Jul 2022 06:43:50 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id b133so6648973pfb.6 for ; Sat, 23 Jul 2022 06:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nPpL7FVl1H6PqS4nSrWEyucV5KSmiF3t3mUkvRlHKBU=; b=33Pvm3siw1zIA/gqHlaxpRttHKirwq32HP3voocw7GvlH7yCIugm82MXFYusTQBr68 knM800EJZgRHqXkSz7vdMPH3+5nKTta1dlmxzWt1AqMHiPlfYhv0qE8Lmd67TKIE8cXK rQN5NAzCXFChsjY2ct3ErpJIaAVOoyjfoH/sp22cfnNJAudeIYuaprca7rtdbQIfPEMM o2S1DnSjoLj7gxj3OOKF3zmA0043M82rpl8M+OCxC19U9RBfGtjyWE369bahfWSt2Txg K+a38XrTyNcnAJgQhy0yydkXBJRwQHzyyX8LwMGfX8ANV+E9J63tSjuXbvJocqeDTSnn 6aYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nPpL7FVl1H6PqS4nSrWEyucV5KSmiF3t3mUkvRlHKBU=; b=kPqaVwvKK86kWdyjDHaYLaut8eqgAHxqKCFQ9/JHbXtJgjXZZz6F6BPLLS3n4x5olo ASmOx3MqEnIo7vf1W1AmKL3GV43yNN8fhNzjPfdon896Xh1bWhZN+QSZ7ETgF47Phy0n T0mmwshdM5/JxeXSv826tIh+Vt4fZy57Vr6RaJ2Gmkid/CTwBcD7cR6aRi4vM9KQYfPg gT7Owp9oLtgCDd9EpuMIxJF5M5ftl2IOZSQTkbtKDjczt4Gq2VUza1ly5OSwx+ulVPUP jKV5PlhF0FRI06lFPN3isUExJ3zV2UI0T1w3HVt4827bCAzU0xi8Gnqo8N0ipbsiz3Nr eFIA== X-Gm-Message-State: AJIora/MiZ3l3oO7g87fqPpEt4P2BbU2FfjoXYzu0MGwTfk38CvCPe+h WvGUCdCqY57IdVlOSqtVO5ng4w== X-Google-Smtp-Source: AGRyM1t+byhgVDc1TwUk8OX/9xUITk45nLbmuKiSJ1MhpGu0O/05x8iTrTMZreaVyvjjKObbuO3KvA== X-Received: by 2002:a63:31d3:0:b0:412:a9d9:d407 with SMTP id x202-20020a6331d3000000b00412a9d9d407mr3953747pgx.479.1658583830231; Sat, 23 Jul 2022 06:43:50 -0700 (PDT) Received: from localhost ([139.177.225.241]) by smtp.gmail.com with ESMTPSA id n13-20020a170902e54d00b0016c38eb1f3asm5895681plf.214.2022.07.23.06.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jul 2022 06:43:49 -0700 (PDT) Date: Sat, 23 Jul 2022 21:43:45 +0800 From: Muchun Song To: Jiebin Sun Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, tim.c.chen@intel.com, ying.huang@intel.com, amadeuszx.slawinski@linux.intel.com, tianyou.li@intel.com, wangyang.guo@intel.com Subject: Re: [PATCH] mm: Remove the redundant updating of stats_flush_threshold Message-ID: References: <20220722164949.47760-1-jiebin.sun@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220722164949.47760-1-jiebin.sun@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote: > From: jiebin sun > > Remove the redundant updating of stats_flush_threshold. If the > global var stats_flush_threshold has exceeded the trigger value > for __mem_cgroup_flush_stats, further increment is unnecessary. > > Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads). > > Score gain: 1.95x > Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%) > > CPU: ICX 8380 x 2 sockets > Core number: 40 x 2 physical cores > Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads) > > Signed-off-by: Jiebin Sun Acked-by: Muchun Song Thanks.