From: Mark Brown <broonie@kernel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh+dt@kernel.org, quic_plai@quicinc.com,
bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: qcom: SC7280: Add support for external DMIC bias supply
Date: Thu, 28 Jul 2022 15:22:29 +0100 [thread overview]
Message-ID: <YuKbpXVOeGn2l2gd@sirena.org.uk> (raw)
In-Reply-To: <1659016789-9933-1-git-send-email-quic_srivasam@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Thu, Jul 28, 2022 at 07:29:49PM +0530, Srinivasa Rao Mandadapu wrote:
> Update SC7280 machine driver for enabling external dmic bias supply,
> which is required for villager evt boards.
> +++ b/sound/soc/qcom/sc7280.c
> @@ -356,6 +356,7 @@ static const struct snd_soc_ops sc7280_ops = {
> static const struct snd_soc_dapm_widget sc7280_snd_widgets[] = {
> SND_SOC_DAPM_HP("Headphone Jack", NULL),
> SND_SOC_DAPM_MIC("Headset Mic", NULL),
> + SND_SOC_DAPM_REGULATOR_SUPPLY("DMICVDD", 0, 0),
> };
>
> static int sc7280_snd_platform_probe(struct platform_device *pdev)
Don't you want to connect this to something? This won't do anything
as-is. I can't see any references to DMICVDD which might be failing to
resolve in the current sound/soc/qcom.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-28 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 13:59 Srinivasa Rao Mandadapu
2022-07-28 14:22 ` Mark Brown [this message]
2022-07-28 16:09 ` Srinivasa Rao Mandadapu
2022-07-29 8:39 ` Srinivas Kandagatla
2022-07-29 12:03 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuKbpXVOeGn2l2gd@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®