From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, sakari.ailus@linux.intel.com,
ribalda@chromium.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: v4l2: Fix comment typo
Date: Thu, 4 Aug 2022 19:19:32 +0300 [thread overview]
Message-ID: <YuvxlOlGmPTbblaP@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220804120504.58083-1-wangborong@cdjrlc.com>
Hi Jason,
On Thu, Aug 04, 2022 at 08:05:04PM +0800, Jason Wang wrote:
> The double `the' is duplicated in the comment, remove one.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
> index e6fd355a2e92..af75edee898c 100644
> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
> @@ -1045,7 +1045,7 @@ static void v4l_sanitize_format(struct v4l2_format *fmt)
> /*
> * The v4l2_pix_format structure has been extended with fields that were
> * not previously required to be set to zero by applications. The priv
> - * field, when set to a magic value, indicates the the extended fields
> + * field, when set to a magic value, indicates the extended fields
I wonder if the original intent was to write "indicates that the
extended fields ...".
> * are valid. Otherwise they will contain undefined values. To simplify
> * the API towards drivers zero the extended fields and set the priv
> * field to the magic value when the extended pixel format structure
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2022-08-04 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 12:05 Jason Wang
2022-08-04 16:19 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvxlOlGmPTbblaP@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=wangborong@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®