From: Borislav Petkov <bp@alien8.de>
To: Zhihao Lin <zh.lin@mail.utoronto.ca>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Logging Behavior under arch/x86/kernel
Date: Fri, 19 Aug 2022 20:06:21 +0200 [thread overview]
Message-ID: <Yv/RHa3fCwVhDaIo@zn.tnic> (raw)
In-Reply-To: <YT3PR01MB87565C391CB407D2BB49BB3BA06D9@YT3PR01MB8756.CANPRD01.PROD.OUTLOOK.COM>
Hi,
On Thu, Aug 18, 2022 at 03:08:44PM +0000, Zhihao Lin wrote:
> 2. At the end of wakeup_secondary_cpu_via_init, send_status is
> checked and given an error-level log message. However, according
> to the control flow analysis, it is unclear that which of
> safe_apic_wait_icr_idle (line 870 or line 918) is checked because
> the loop (which contains the third call) may or may not execute.
Well, does it matter which is checked?
AFAICT, it always checks the right one. :-)
> In this case, my tool alerts that this log statement doesn’t provide
> sufficient information for error diagnostic.
The pr_err() calls at the end of the function do catch the case when
either send_status or accept_status are != 0.
> pci_write_config_dword
>
> * arch/x86/kernel/amd_nb.c
That has been probably overlooked during review. If we had to be
pedantic, we should check all those retvals. I guess not that
important...
HTH.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
parent reply other threads:[~2022-08-19 18:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <YT3PR01MB87565C391CB407D2BB49BB3BA06D9@YT3PR01MB8756.CANPRD01.PROD.OUTLOOK.COM>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv/RHa3fCwVhDaIo@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zh.lin@mail.utoronto.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®