From: Xu Yilun <yilun.xu@intel.com>
To: Peter Colberg <peter.colberg@intel.com>
Cc: Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
russell.h.weight@intel.com, matthew.gerlach@linux.intel.com,
basheer.ahmed.muddebihal@intel.com, tianfei.zhang@intel.com,
marpagan@redhat.com, lgoncalv@redhat.com
Subject: Re: [PATCH v1] uio: dfl: add IOPLL user-clock feature id
Date: Thu, 18 Aug 2022 12:18:02 +0800 [thread overview]
Message-ID: <Yv29ev8OKyEYcaf/@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20220817213746.4986-1-peter.colberg@intel.com>
On 2022-08-17 at 17:37:46 -0400, Peter Colberg wrote:
> Add a Device Feature List (DFL) feature id for the configurable
> IOPLL user clock source, which can be used to configure the clock
> speeds that are used for RTL logic that is programmed into the
> Partial Reconfiguration (PR) region of an FPGA.
Why not use linux clock framework for this IOPLL? And let the PR
driver set it togeter with the RTL logic reporgramming?
Thanks,
Yilun
>
> The DFL feature id table can be found at:
> https://github.com/OPAE/dfl-feature-id
>
> Signed-off-by: Peter Colberg <peter.colberg@intel.com>
> ---
> drivers/uio/uio_dfl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 8f39cc8bb034..69e93f3e7faf 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -46,10 +46,12 @@ static int uio_dfl_probe(struct dfl_device *ddev)
>
> #define FME_FEATURE_ID_ETH_GROUP 0x10
> #define FME_FEATURE_ID_HSSI_SUBSYS 0x15
> +#define PORT_FEATURE_ID_IOPLL_USRCLK 0x14
>
> static const struct dfl_device_id uio_dfl_ids[] = {
> { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> { FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> + { PORT_ID, PORT_FEATURE_ID_IOPLL_USRCLK },
> { }
> };
> MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
> --
> 2.28.0
>
next prev parent reply other threads:[~2022-08-18 4:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 21:37 Peter Colberg
2022-08-18 4:18 ` Xu Yilun [this message]
2022-08-18 23:38 ` Russ Weight
2022-08-22 4:49 ` Xu Yilun
2022-08-22 17:38 ` Russ Weight
2022-08-22 20:06 ` Tom Rix
2022-08-23 1:21 ` Xu Yilun
2022-08-26 15:01 ` [PATCH v2] " Peter Colberg
2022-08-27 5:54 ` Xu Yilun
2022-08-31 20:48 ` [PATCH v3] " Peter Colberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv29ev8OKyEYcaf/@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=basheer.ahmed.muddebihal@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=peter.colberg@intel.com \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®