From: Paul Lemmermann <thepaulodoom@thepaulodoom.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int'
Date: Thu, 18 Aug 2022 20:52:37 -0500 [thread overview]
Message-ID: <Yv7s5dedhRaDlsAC@gus-fring.localdomain> (raw)
In-Reply-To: <Yv5SG8XMR2mZGAqG@kroah.com>
On Thu, Aug 18, 2022 at 04:52:11PM +0200, Greg KH wrote:
> On Tue, Aug 16, 2022 at 08:35:31PM -0500, Paul Lemmermann wrote:
> > found with checkpatch.pl
>
> That is a very sparse changelog text.
>
> Why make this change? Please be descriptive.
>
I wanted to make this change to be more fitting with the kernel coding
guidelines, and to reduce a WARNING made with checkpatch preferring the
use of 'unsigned int' over 'unsigned'. With NOMMU_MAP_COPY defined in
'include/linux/fs.h' as an unsigned integer, I felt like the change was
fitting. I was quickly reminded that the changelog was not properly done,
and I now understand that, and will learn from my mistake in the future.
As I am a new kernel contributor, and looking to hone my skills, what are
my next steps?
Should I:
o Drop the patch and resubmit it,
o Simply drop the patch,
o Could I change it somehow?,
o Or something else?
Thank you very much for your time and effort,
- Paul
P.S. Resending this as reply all, as I quickly relized I forgot to do
after I send the email to Greg.
next prev parent reply other threads:[~2022-08-19 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 1:35 Paul Lemmermann
2022-08-17 2:09 ` [PATCH] improve the kernel quality and reduce the amount of BS patches Al Viro
2022-08-17 2:18 ` Al Viro
2022-08-17 2:29 ` Randy Dunlap
2022-08-18 5:48 ` Joe Perches
2022-08-18 14:52 ` [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int' Greg KH
2022-08-19 1:52 ` Paul Lemmermann [this message]
2022-08-21 8:35 ` Greg KH
2022-08-21 15:49 ` ThePaulODoom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv7s5dedhRaDlsAC@gus-fring.localdomain \
--to=thepaulodoom@thepaulodoom.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®