From: Simon Horman <horms@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Julian Anastasov <ja@ssi.bg>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy
Date: Fri, 19 Aug 2022 11:50:01 +0200 [thread overview]
Message-ID: <Yv9cya3UyvJsh0Ah@vergenet.net> (raw)
In-Reply-To: <20220818210224.8563-1-wsa+renesas@sang-engineering.com>
On Thu, Aug 18, 2022 at 11:02:24PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks Wolfram,
FWIIW, for the IPVS portion:
Reviewed-by: Simon Horman <horms@verge.net.au>
> ---
> net/netfilter/ipset/ip_set_core.c | 4 ++--
> net/netfilter/ipvs/ip_vs_ctl.c | 8 ++++----
> net/netfilter/nf_log.c | 4 ++--
> net/netfilter/nf_tables_api.c | 2 +-
> net/netfilter/nft_osf.c | 2 +-
> net/netfilter/x_tables.c | 20 ++++++++++----------
> net/netfilter/xt_RATEEST.c | 2 +-
> 7 files changed, 21 insertions(+), 21 deletions(-)
...
prev parent reply other threads:[~2022-08-19 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 21:02 Wolfram Sang
2022-08-18 22:11 ` Florian Westphal
2022-08-19 9:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv9cya3UyvJsh0Ah@vergenet.net \
--to=horms@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®