From: Mark Brown <broonie@kernel.org>
To: Patrice CHOTARD <patrice.chotard@foss.st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, christophe.kerello@foss.st.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] spi: stm32_qspi: Add transfer_one_message() spi callback
Date: Mon, 8 Aug 2022 17:15:28 +0100 [thread overview]
Message-ID: <YvE2oN7EDDFLlxyv@sirena.org.uk> (raw)
In-Reply-To: <bbe8f91e-35f4-fe80-4b6e-25d21a6547fc@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On Mon, Aug 08, 2022 at 06:09:51PM +0200, Patrice CHOTARD wrote:
> On 8/8/22 15:29, Mark Brown wrote:
> > On Mon, Aug 08, 2022 at 09:40:50AM +0200, patrice.chotard@foss.st.com wrote:
> >> + ret = pm_runtime_get_sync(qspi->dev);
> >> + if (ret < 0) {
> >> + pm_runtime_put_noidle(qspi->dev);
> >> + return ret;
> >> + }
> > Use the core runtime PM, there should be no need to open code.
> Right, i will use pm_runtime_resume_and_get() instead.
There's also core SPI support for calling this - set auto_runtime_pm.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-08 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 7:40 [PATCH 0/3] spi: stm32_qspi: use QSPI bus as 8 lines communication channel patrice.chotard
2022-08-08 7:40 ` [PATCH 1/3] dt-bindings: spi: stm32: Add st,dual-flash property in st,stm32-qspi.yaml patrice.chotard
2022-08-08 9:01 ` Krzysztof Kozlowski
2022-08-08 16:08 ` Patrice CHOTARD
2022-08-09 4:18 ` Krzysztof Kozlowski
2022-08-09 5:29 ` Krzysztof Kozlowski
2022-08-09 7:52 ` Patrice CHOTARD
2022-08-09 7:57 ` Krzysztof Kozlowski
2022-08-09 8:00 ` Patrice CHOTARD
2022-08-08 7:40 ` [PATCH 2/3] spi: stm32_qspi: Add transfer_one_message() spi callback patrice.chotard
2022-08-08 13:29 ` Mark Brown
2022-08-08 16:09 ` Patrice CHOTARD
2022-08-08 16:15 ` Mark Brown [this message]
2022-08-08 7:40 ` [PATCH 3/3] ARM: dts: stm32: Create separate pinmux for qspi cs pin in stm32mp15-pinctrl.dtsi patrice.chotard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvE2oN7EDDFLlxyv@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christophe.kerello@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=patrice.chotard@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®