From: Al Viro <viro@zeniv.linux.org.uk>
To: Jeff Layton <jlayton@kernel.org>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [GIT PULL] Ceph updates for 5.20-rc1
Date: Thu, 11 Aug 2022 22:22:37 +0100 [thread overview]
Message-ID: <YvVzHQ5DVaPAvw26@ZenIV> (raw)
In-Reply-To: <5d0b0367a5e28ec5b1f3b995c7792ff9a5cbcbd4.camel@kernel.org>
On Thu, Aug 11, 2022 at 05:08:11PM -0400, Jeff Layton wrote:
> Actually, I never got a formal ack from Al. I did send it repeatedly,
> but I assume he has been too busy to respond. We've had it sitting in
> linux-next for a couple of months, and he did suggest that approach in
> the first place, but I too would also prefer to see his official ack on
> it.
"Suggested approach" had been about inode_insert5() changes, right?
But that's fs/inode.c side of things... I have to admit that I'd missed
the unlining d_same_name() - exporting the sucker per se didn't look
insane and I hadn't looked at that in details ;-/
Looking at it now... might be worth renaming it into __d_same_name(),
leaving it inlined and exporting a wrapper; not sure if the impact on
d_lookup()/__d_lookup()/d_alloc_parallel() is worth worrying about it,
though.
Profiling a case when we have a plenty of files in the same directory
on tmpfs, with something earlier in the pathname to kick out of RCU
mode (e.g. going through /proc/self/cwd) might be interesting...
next prev parent reply other threads:[~2022-08-11 21:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 15:24 Ilya Dryomov
2022-08-11 20:03 ` Linus Torvalds
2022-08-11 20:55 ` Ilya Dryomov
2022-08-11 21:08 ` Jeff Layton
2022-08-11 21:22 ` Al Viro [this message]
2022-08-11 21:23 ` Al Viro
2022-08-11 21:30 ` Jeff Layton
2022-08-11 21:38 ` Al Viro
2022-08-11 21:52 ` Linus Torvalds
2022-08-11 22:04 ` Al Viro
2022-08-11 22:22 ` Linus Torvalds
2022-08-11 22:43 ` Linus Torvalds
2022-08-12 3:58 ` Linus Torvalds
2022-08-14 19:08 ` Al Viro
2022-08-14 20:03 ` Linus Torvalds
2022-08-14 20:29 ` Linus Torvalds
2022-08-14 21:20 ` Nick Desaulniers
2022-08-11 22:44 ` Al Viro
2022-08-11 21:29 ` Linus Torvalds
2022-08-11 21:32 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvVzHQ5DVaPAvw26@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®