From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A49BC00140 for ; Fri, 12 Aug 2022 12:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237834AbiHLMdh (ORCPT ); Fri, 12 Aug 2022 08:33:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbiHLMdg (ORCPT ); Fri, 12 Aug 2022 08:33:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33FDAA4D2 for ; Fri, 12 Aug 2022 05:33:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DA3661712 for ; Fri, 12 Aug 2022 12:33:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D419C433C1; Fri, 12 Aug 2022 12:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660307614; bh=FUfc1TFo94swYywRR9ki3WQ1R4VUwdEZ+9NUnE3thjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q4KOADSOuJUBf44A8BVVm9ZGOfi3J+RRo3RCr8qQQBV1gTQPgGscyjU+VsRWfko7x cOZwfNKqBcU4N/wYGexx3EPC+IPHBFpwKMNc3Qq6CI+4NJqt4g7Jy8u7mozZM/rUCk wxD/yvnyfxyRttL7D+ZUcvGc7fnff2WPSlomPe/1COUP5/6rCtzT7wcRt+pWv0q1z2 GLGWHlHoRNfBymjNYt0BFbMclTHfymRnLj04KhNMbxpsQ/J4hx9gK1rJtMwgk1qPbg cdG+sshiD3X77prvAUPcBdnMkgaXdk5BjzqGMI8NVzB4Rt0ZWmMdruFr3rhayRtgu4 YEwhJKQIV+Pdg== Date: Fri, 12 Aug 2022 13:33:29 +0100 From: Mark Brown To: Syed Saba kareem Cc: alsa-devel@alsa-project.org, Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, mario.limonciello@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH 03/13] ASoC: amd: add acp6.2 init/de-init functions Message-ID: References: <20220812120731.788052-1-Syed.SabaKareem@amd.com> <20220812120731.788052-4-Syed.SabaKareem@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B0pljCE077v7zEjS" Content-Disposition: inline In-Reply-To: <20220812120731.788052-4-Syed.SabaKareem@amd.com> X-Cookie: No foreign coins. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --B0pljCE077v7zEjS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 12, 2022 at 05:37:21PM +0530, Syed Saba kareem wrote: > + /* power on */ > + ret = acp62_power_on(acp_base); > + if (ret) { > + pr_err("ACP power on failed\n"); > + return ret; > + } It would be better if you passed the device in so messages like this could be dev_err() rather than just pr_err(). --B0pljCE077v7zEjS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL2SJgACgkQJNaLcl1U h9DlOQf9HdVqSnXnN96Td4SQOGqazW0R4j9ss0dhrbUPKYN9e/+jEcE184D1mqqi v1xQCwSPhsHWIp0E6CcV7j7j6gZP9mN8S+IZbtlbCRX+OryIXtBnmqvQA74j4Eod 7H5+FsPWXNpni76NvzfFiEaNXTZZMGUb7jmjqJ78D1mWYju46F5yHpbFgilVvHkf j343RbHp3Xj+iZBPcmapv8tVIInoLBYv2nqfpioycJG/WAIi1k5rLNDJ6C0TyhAw q6LwW4vmo/jptfJsaWYNwI7mCZh992XmhlGctC7sUy1Uxe+iwAnDvIrM/AHkV2qW XAei8F1c0rFanUkRCuzPEkVJtoNZvw== =EBfU -----END PGP SIGNATURE----- --B0pljCE077v7zEjS--