From: Tejun Heo <tj@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Johannes Berg <johannes.berg@intel.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Hillf Danton <hdanton@sina.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] workqueue: don't skip lockdep work dependency in cancel_work_sync()
Date: Mon, 15 Aug 2022 11:16:00 -1000 [thread overview]
Message-ID: <Yvq3kH9b4IEyodRK@slm.duckdns.org> (raw)
In-Reply-To: <77d47eed-6a22-7e81-59de-4d45852ca4de@I-love.SAKURA.ne.jp>
On Fri, Jul 29, 2022 at 01:30:23PM +0900, Tetsuo Handa wrote:
> Like Hillf Danton mentioned
>
> syzbot should have been able to catch cancel_work_sync() in work context
> by checking lockdep_map in __flush_work() for both flush and cancel.
>
> in [1], being unable to report an obvious deadlock scenario shown below is
> broken. From locking dependency perspective, sync version of cancel request
> should behave as if flush request, for it waits for completion of work if
> that work has already started execution.
Applied to cgroup/for-6.0-fixes.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-08-16 1:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 12:23 [PATCH] workqueue: don't skip lockdep wq " Tetsuo Handa
2022-07-28 16:40 ` Tejun Heo
2022-07-28 23:18 ` Tetsuo Handa
2022-07-29 1:49 ` Tetsuo Handa
2022-07-29 2:28 ` Tetsuo Handa
2022-07-29 2:49 ` Tetsuo Handa
2022-07-29 2:54 ` [PATCH v2] workqueue: don't skip lockdep work " Tetsuo Handa
2022-07-29 4:30 ` [PATCH v3] " Tetsuo Handa
2022-08-15 21:16 ` Tejun Heo [this message]
2023-09-13 14:28 ` Guenter Roeck
2023-09-13 14:41 ` Johannes Berg
2023-09-13 15:59 ` Guenter Roeck
2023-09-13 17:25 ` Florian Fainelli
2023-09-13 17:45 ` Guenter Roeck
2023-09-13 18:30 ` Johannes Berg
2023-09-13 18:11 ` Johannes Berg
2022-07-29 2:38 ` [PATCH] workqueue: don't skip lockdep wq " Lai Jiangshan
2022-07-29 2:49 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvq3kH9b4IEyodRK@slm.duckdns.org \
--to=tj@kernel.org \
--cc=hdanton@sina.com \
--cc=jiangshanlai@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®