mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Thierry Guibert <thierry.guibert@croix-rouge.fr>
Cc: oneukum@suse.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CDC-ACM : Add Icom PMR F3400 support (0c26:0020)
Date: Tue, 16 Aug 2022 18:20:05 +0200	[thread overview]
Message-ID: <YvvDtUi7zgrYlopw@kroah.com> (raw)
In-Reply-To: <CAEzRux_E+EAEkdr8RVGq4BTJ87G75fwXf4gveLTmk_P3nxizvw@mail.gmail.com>

On Tue, Aug 16, 2022 at 06:14:21PM +0200, Thierry Guibert wrote:
> >From cf6471caeee7ac7d92bfa4ceaaa16ab461846e65 Mon Sep 17 00:00:00 2001
> From: Thierry GUIBERT <thierry.guibert@croix-rouge.fr>
> Date: Tue, 16 Aug 2022 00:46:01 +0200
> Subject: [PATCH] CDC-ACM : Add Icom PMR F3400 support (0c26:0020)

Why is this in the email body?

Are you using 'git send-email' for this?

> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 9b9aea24d58c..091fcfac3717 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1813,6 +1813,10 @@ static const struct usb_device_id acm_ids[] = {
>        { USB_DEVICE(0x0ca6, 0xa050), /* Castles VEGA3000 */
>        .driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
>        },
> +       { USB_DEVICE(0x0c26, 0x0020), /* Icom ICF3400 Serie */
> +       .driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
> +       },
> +
> 
>        { USB_DEVICE(0x2912, 0x0001), /* ATOL FPrint */
>        .driver_info = CLEAR_HALT_CONDITIONS,
> --
> 2.37.2

As my bot pointed out many times, this is whitespace corrupted and can
not be applied :(

Please fix up your email client and resend a v2.

thanks,

greg k-h

  reply	other threads:[~2022-08-16 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 16:14 Thierry Guibert
2022-08-16 16:20 ` Greg KH [this message]
     [not found]   ` <CAEzRux-PG6Fe3qr1kmHqr-tbozmzkpOmM89UAXH-44BuYYcUpA@mail.gmail.com>
2022-08-17  6:17     ` Greg KH
2022-08-16 21:12 Thierry GUIBERT
2022-08-16 21:28 Thierry GUIBERT
2022-08-17  6:17 ` Greg KH
2022-08-17 10:24 Thierry GUIBERT
2022-08-18 15:04 ` Greg KH
2022-08-18 16:54   ` Thierry GUIBERT
2022-08-18 16:59     ` Greg KH
2022-08-19  8:17 Thierry GUIBERT
2022-08-19  9:12 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvvDtUi7zgrYlopw@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=thierry.guibert@croix-rouge.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome