mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Imran Khan <imran.f.khan@oracle.com>
Cc: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RESEND PATCH 4/5] kernfs: Replace per-fs rwsem with hashed rwsems.
Date: Tue, 16 Aug 2022 12:42:18 -1000	[thread overview]
Message-ID: <YvwdShstDCK+uQ+R@slm.duckdns.org> (raw)
In-Reply-To: <20220810111017.2267160-5-imran.f.khan@oracle.com>

Hello,

I'm bandwidth constrained right now and can't really shepherd this patchset,
so I'm not gonna ack or nack the series. That said, here are my thoughts
after glancing through it:

* I find the returning-with-rwsem-held interface and usage odd. We return
  with locks held all the time, so that part in itself is fine but how it's
  used in the proposed patch is pretty alien.

* I don't understand why the topo_mutex is needed. What is its relationship
  with rename_lock?

* Can't the double/triple lock helpers loop over the sorted list instead of
  if'ing each case?

Thanks.

-- 
tejun

  reply	other threads:[~2022-08-16 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 11:10 [RESEND PATCH 0/5] kernfs: Use a per-fs rwsem to protect per-fs list of kernfs_super_info Imran Khan
2022-08-10 11:10 ` [RESEND PATCH 1/5] " Imran Khan
2022-08-10 11:10 ` [RESEND PATCH 2/5] kernfs: Change kernfs_rename_lock into a read-write lock Imran Khan
2022-08-10 11:10 ` [RESEND PATCH 3/5] kernfs: Introduce interface to access per-fs rwsem Imran Khan
2022-08-10 11:10 ` [RESEND PATCH 4/5] kernfs: Replace per-fs rwsem with hashed rwsems Imran Khan
2022-08-16 22:42   ` Tejun Heo [this message]
2022-11-13 17:30     ` Imran Khan
2023-01-04  9:11       ` Imran Khan
2022-08-10 11:10 ` [RESEND PATCH 5/5] kernfs: Add a document to describe hashed locks used in kernfs Imran Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvwdShstDCK+uQ+R@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imran.f.khan@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®