From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E87C25B08 for ; Wed, 17 Aug 2022 06:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238699AbiHQGBF (ORCPT ); Wed, 17 Aug 2022 02:01:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiHQGBC (ORCPT ); Wed, 17 Aug 2022 02:01:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42777E814; Tue, 16 Aug 2022 23:01:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29C20B81AD3; Wed, 17 Aug 2022 06:00:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 935ACC433C1; Wed, 17 Aug 2022 06:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660716057; bh=gWyhQ2vSiY3PQDsc2PdJGtbgVKekpF295CaCysh1iv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2M9o6st8sa8fcPWhiVAkDuaEij9ALqXx9OFeqZBqBS5Za/mjTseMg24nLfeoNBayl fcR4MlMOgs0uX1kLl47wU8sCHO5VCdQeVnSbzxAkbJQTdAHrICXlNMtSh055bJYc3a L7pry/xmwZlFbeWtG+VM77DcRazJmFKgKm/9em/o= Date: Wed, 17 Aug 2022 08:00:54 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , stable@vger.kernel.org Subject: Re: [PATCH v2] usb: typec: tcpm: Return ENOTSUPP for power supply prop writes Message-ID: References: <20220816191150.1432166-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816191150.1432166-1-badhri@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 12:11:50PM -0700, Badhri Jagan Sridharan wrote: > When the port does not support USB PD, prevent transition to PD > only states when power supply property is written. In this case, > TCPM transitions to SNK_NEGOTIATE_CAPABILITIES > which should not be the case given that the port is not pd_capable. > > [ 84.308251] state change SNK_READY -> SNK_NEGOTIATE_CAPABILITIES [rev3 NONE_AMS] > [ 84.308335] Setting usb_comm capable false > [ 84.323367] set_auto_vbus_discharge_threshold mode:3 pps_active:n vbus:5000 ret:0 > [ 84.323376] state change SNK_NEGOTIATE_CAPABILITIES -> SNK_WAIT_CAPABILITIES [rev3 NONE_AMS] > > Fixes: e9e6e164ed8f6 ("usb: typec: tcpm: Support non-PD mode") > Signed-off-by: Badhri Jagan Sridharan > --- > Changes since v1: > - Add Fixes tag. > --- > drivers/usb/typec/tcpm/tcpm.c | 7 +++++++ > 1 file changed, 7 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.