From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C87C25B08 for ; Wed, 17 Aug 2022 13:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239521AbiHQNo7 (ORCPT ); Wed, 17 Aug 2022 09:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231268AbiHQNo4 (ORCPT ); Wed, 17 Aug 2022 09:44:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA3B94EEF; Wed, 17 Aug 2022 06:44:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FF2D61403; Wed, 17 Aug 2022 13:44:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B6EBC433C1; Wed, 17 Aug 2022 13:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660743893; bh=axBECSzV/EqfT0Sn05l3MHwC6tk13jz5uq2PwFJrwcg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IKByo38T17YV6cNWZZl0rJZRGDfiecze0MgLBe36G0uCpz1QXq1sDSqpLNsi0MByc jfx1y0Q78Ey1XCVc374+QNXBGg5S5/tj69bMDJwXwn6YIo20LVzDJEAL+ugax6C3/u tcdZWyMu+feSH3nrDPjzpTVUP492ynZYj13J4v86ENKCefqvRtEq53r6gyDddDb4tp T/wyc209XPcAFl/qCEFJDy8tVU+rPH+Cp4LYNJFnONiuGywqzTfdittKnhMjzLSZIx fOdI3UY9n4FDtm4D8CtTJR+NSGVrGT8HYKeQubadJY6rgNu1ZNXYNe7yCqhv6C7OV8 8oYW1AiHSkZGA== Date: Wed, 17 Aug 2022 14:44:48 +0100 From: Mark Brown To: Shreeya Patel Cc: sanju.mehta@amd.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com, krisman@collabora.com, alvaro.soliverez@collabora.com, Lucas Tanure Subject: Re: [PATCH] spi: amd: Configure device speed Message-ID: References: <20220817131809.312533-1-shreeya.patel@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6FocHUaNXur4kiU0" Content-Disposition: inline In-Reply-To: <20220817131809.312533-1-shreeya.patel@collabora.com> X-Cookie: Use extra care when cleaning on stairs. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6FocHUaNXur4kiU0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 17, 2022 at 06:48:09PM +0530, Shreeya Patel wrote: > Create mechanism to configure device clock frequency such > that it is the closest frequency supported by the > AMD controller. You shouldn't use the closest, you should use a frequency which is strictly less than the requested one - driving things too fast will generally break but too slow is pretty much always fine. --6FocHUaNXur4kiU0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL88M8ACgkQJNaLcl1U h9Bw1wf/ZyAh2aIJGCThq2MRGZPYvLvL2UXlzTF0y6ANGohcz3kYFgyEg2GeTf22 YGrIH7UuqTEb+jWL7sews+gNZ04cB1AYSphvkamTlVFARillpOteigu10mX72p1i F3NY3qJ9jPzFP+jVu/Wx8B7lROHuVJ0D9Fw4W6Bu0tfjyjsu73X6KmaVCA5XRmVt zKZKQswcTmr5Ce/kBk+i7CbOmqnZ+eXtEUp9sFulcxFFFfdAVdDogjktFEGy4mna bU2ougQgzHyttoXNedBN0S8ih7YjULeyr2qlbZnoXOtvOXHVjg0dpimBRYiglLn4 hG75Lu+wV/IIvp+3F35IbWGkzA44hw== =scUh -----END PGP SIGNATURE----- --6FocHUaNXur4kiU0--