From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix rebase error
Date: Thu, 1 Sep 2022 00:30:16 +0300 [thread overview]
Message-ID: <Yw/S6NjDcd/JeZCG@smile.fi.intel.com> (raw)
In-Reply-To: <20220831141303.501548-1-linus.walleij@linaro.org>
On Wed, Aug 31, 2022 at 04:13:03PM +0200, Linus Walleij wrote:
> A dangling pointless "ret 0" was left in and some unneeded
> whitespace can go too.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 81c0386c1376 ("regmap: mmio: Support accelerared noinc operations")
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/base/regmap/regmap-mmio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/regmap/regmap-mmio.c b/drivers/base/regmap/regmap-mmio.c
> index e8d2675463ac..b47ee3e8d050 100644
> --- a/drivers/base/regmap/regmap-mmio.c
> +++ b/drivers/base/regmap/regmap-mmio.c
> @@ -410,14 +410,11 @@ static int regmap_mmio_noinc_read(void *context, unsigned int reg,
> }
> }
>
> -
> out_clk:
> if (!IS_ERR(ctx->clk))
> clk_disable(ctx->clk);
>
> return ret;
> -
> - return 0;
> }
>
>
> --
> 2.37.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-08-31 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 14:13 Linus Walleij
2022-08-31 21:30 ` Andy Shevchenko [this message]
2022-09-01 12:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw/S6NjDcd/JeZCG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®