From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09AEECAAD2 for ; Mon, 29 Aug 2022 23:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229486AbiH2XIq (ORCPT ); Mon, 29 Aug 2022 19:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiH2XIm (ORCPT ); Mon, 29 Aug 2022 19:08:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 674857CB49; Mon, 29 Aug 2022 16:08:39 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 90431481; Tue, 30 Aug 2022 01:08:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661814516; bh=V/noL5H3GGat0X1qZ40oI+6OfQ6QMlmf7rC/4vB+poY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=liE817KLQtHDm3GEbvXYnedB96v9ivXs4fQlkLc2UOi/l+cAVbqGII2V1UvJ3dDke 1DF/inO4KuoaB+FNGd1bxvt53gRAy381yS0GEZ1YU9ojkb80WeNk4Kl2rvcvLxGzZv aXw7BCWF2W6GEwvaL0fYudC5jljkpIVyrZe2XMNM= Date: Tue, 30 Aug 2022 02:08:27 +0300 From: Laurent Pinchart To: Lad Prabhakar Cc: Kieran Bingham , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Geert Uytterhoeven , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das Subject: Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings Message-ID: References: <20220829215816.6206-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220829215816.6206-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, Thank you for the patch. On Mon, Aug 29, 2022 at 10:58:16PM +0100, Lad Prabhakar wrote: > With 'unevaluatedProperties' support implemented, there's a number of > warnings when running dtbs_check: > > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected) > From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > > The main problem is that SoC DTSI's are including resets property, whereas > the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add > optional resets property to the binding. Given that all the DT sources in the kernel specify the resets property, how about making it mandatory ? Reviewed-by: Laurent Pinchart > Signed-off-by: Lad Prabhakar > --- > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > index 0c9785c8db51..a7e44e249dd3 100644 > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > @@ -38,6 +38,9 @@ properties: > clock-names: > maxItems: 2 > > + resets: > + maxItems: 1 > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > -- Regards, Laurent Pinchart