From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D13ECAAA1 for ; Tue, 30 Aug 2022 12:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiH3Mrs (ORCPT ); Tue, 30 Aug 2022 08:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiH3Mrq (ORCPT ); Tue, 30 Aug 2022 08:47:46 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D86C8ABD64; Tue, 30 Aug 2022 05:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3DFiWf/O2nEaK0RaIY+HnSISDVWcCiaB89634qTWNxY=; b=3atNH1u7rzWigXKovzGkZsKbF7 xfCv9cZKzJPsNhPMA6HAYnjVenVH3yWIRe7VQFK3gBWsdrcpuT/S1bCsXbz15GgyGvCWp1UACwFkj GwByX0f2UEQ1e4IQjGqBAHHwIPfezuJM643gdLEFI5I8kwHJbjymxT2AKadDA9bUSm8M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oT0ee-00F4Xx-9h; Tue, 30 Aug 2022 14:47:44 +0200 Date: Tue, 30 Aug 2022 14:47:44 +0200 From: Andrew Lunn To: Arun Ramadoss Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Woojung Huh , UNGLinuxDriver@microchip.com, Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Tristram Ha Subject: Re: [RFC Patch net-next v3 2/3] net: dsa: microchip: add reference to ksz_device inside the ksz_port Message-ID: References: <20220830105303.22067-1-arun.ramadoss@microchip.com> <20220830105303.22067-3-arun.ramadoss@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830105303.22067-3-arun.ramadoss@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 04:23:02PM +0530, Arun Ramadoss wrote: > struct ksz_port doesn't have reference to ksz_device as of now. In order > to find out from which port interrupt has triggered, we need to pass the > struct ksz_port as a host data. When the interrupt is triggered, we can > get the port from which interrupt triggered, but to identify it is phy > interrupt we have to read status register. The regmap structure for > accessing the device register is present in the ksz_device struct. To > access the ksz_device from the ksz_port, the reference is added to it > with port number as well. > > Signed-off-by: Arun Ramadoss Reviewed-by: Andrew Lunn Andrew