mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andrew Halaney <ahalaney@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Andy Gross <agross@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: sc8280xp-crd: Specify which LDO modes are allowed
Date: Wed, 31 Aug 2022 08:43:20 +0200	[thread overview]
Message-ID: <Yw8DCM0Hqxr9ncoO@hovoldconsulting.com> (raw)
In-Reply-To: <20220829094903.v2.3.Ie7d2c50d2b42ef2d364f3a0c8e300e5ce1875b79@changeid>

On Mon, Aug 29, 2022 at 09:49:49AM -0700, Douglas Anderson wrote:
> This board uses RPMH, specifies "regulator-allow-set-load" for LDOs,
> but doesn't specify any modes with "regulator-allowed-modes".
> 
> Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement
> get_optimum_mode(), not set_load()") the above meant that we were able
> to set either LPM or HPM mode. After that commit (and fixes [1]) we'll
> be stuck at the initial mode. Discussion of this has resulted in the
> decision that the old dts files were wrong and should be fixed to
> fully restore old functionality.
> 
> Let's re-enable the old functionality by fixing the dts.
> 
> [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid
> 
> Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> 
> Changes in v2:
> - Rebased atop ("...: sc8280xp-crd: disallow regulator mode switches")

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

  reply	other threads:[~2022-08-31  6:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 16:49 [PATCH v2 0/6] arm64: dts: qcom: Fix broken regulator spec on RPMH boards Douglas Anderson
2022-08-29 16:49 ` [PATCH v2 1/6] arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed Douglas Anderson
2022-08-29 16:49 ` [PATCH v2 2/6] arm64: dts: qcom: sa8295p-adp: " Douglas Anderson
2022-08-31  6:42   ` Johan Hovold
2022-08-29 16:49 ` [PATCH v2 3/6] arm64: dts: qcom: sc8280xp-crd: " Douglas Anderson
2022-08-31  6:43   ` Johan Hovold [this message]
2022-08-29 16:49 ` [PATCH v2 4/6] arm64: dts: qcom: sm8150-xperia-kumano: " Douglas Anderson
2022-08-29 16:49 ` [PATCH v2 5/6] arm64: dts: qcom: sm8250-xperia-edo: " Douglas Anderson
2022-08-29 16:49 ` [PATCH v2 6/6] arm64: dts: qcom: sm8350-hdk: " Douglas Anderson
2022-08-31  6:47 ` [PATCH v2 0/6] arm64: dts: qcom: Fix broken regulator spec on RPMH boards Johan Hovold
2022-08-31 14:52   ` Doug Anderson
2022-08-31 19:00     ` Andrew Halaney
2022-09-02 18:59       ` Andrew Halaney
2022-09-01 15:52     ` Johan Hovold
2022-09-02  0:44       ` Doug Anderson
2022-09-02  5:40         ` Johan Hovold
2022-09-08 16:04 ` Doug Anderson
2022-09-23  0:16   ` Doug Anderson
2022-10-18  3:05 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw8DCM0Hqxr9ncoO@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=agross@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®