From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30340C28D13 for ; Fri, 19 Aug 2022 22:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243108AbiHSWsw (ORCPT ); Fri, 19 Aug 2022 18:48:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242959AbiHSWst (ORCPT ); Fri, 19 Aug 2022 18:48:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86F01753AD for ; Fri, 19 Aug 2022 15:48:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23B8E61831 for ; Fri, 19 Aug 2022 22:48:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFFEC433B5; Fri, 19 Aug 2022 22:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660949327; bh=gJJMr+uLwUVCPzts92iC8fkEyz8iwbsHjS9H2CKktno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSxNMzplA2gu4/xhcncDwTntKN9odHWKv95YC8+mNoUC5/3g6X5a23RegRJeNi6Ae bQfRD7nZsqSn/MtcxQnhRtJtLVpD93A0rnd+ONj1o7+RoOQyPyg7WHv+bu66WDZupE WRn+wKzi3wq96SMg9f/LyxBmM9lN0FrY62EIDgRK5uHQnB1zOnETtyiq56KujueYI+ i2J46Bs1SDx5ch5Ec0geLQU87AtRdDtifjlszVQfzuFtJ4aRhdLCOtkcGWYAYdJlcV zkiYOva1IbPpnNh/3cCymf8Q+3dqDz61VGy+XgyKj5tN56MDKMdwsOC2Hk6/D/YA2A ErCT/L78dsLwQ== Date: Fri, 19 Aug 2022 23:48:42 +0100 From: Mark Brown To: Andrew Halaney Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, bmasney@redhat.com, dianders@chromium.org Subject: Re: [PATCH] regulator: core: Clean up on enable failure Message-ID: References: <20220819194336.382740-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P7YyzzYVLd5ZYWMp" Content-Disposition: inline In-Reply-To: <20220819194336.382740-1-ahalaney@redhat.com> X-Cookie: Process promptly. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --P7YyzzYVLd5ZYWMp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 19, 2022 at 02:43:36PM -0500, Andrew Halaney wrote: > - if (regulator->uA_load && regulator->enable_count == 1) > - return drms_uA_update(rdev); > + if (regulator->uA_load && regulator->enable_count == 1) { > + ret = drms_uA_update(rdev); I am vaugely surprised and a bit concerned that drms_uA_update() can fail... --P7YyzzYVLd5ZYWMp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMAE0oACgkQJNaLcl1U h9A1PQf/SxzOvIgno1rey/F4HXQL7HDaiadmoJVdsBE+O8gVCb7rcCSeZTbYAmfz bYvnjFbeL7EOxKdN9+fsKQGcRMtZik6hrXO3BICTE8IsdgwgzDROL8US6+B9fNTa GSI1QysdkGUfaHbtUxw2xfAqz2fZuc21yBbsT3jDo1iJsAM0evCH04aYj3xE0h6G gBkTeHuMexyvJY+h1onqQ+ZL8Vx5G41K1m38bTbkV2loc/YCpkdNWmxEmdTxA19u LUzhE4JVuIISCoPDMcy6xLC4yQWqgi87oibEMOj1fSyT6NwkoeSx5zcersyviWuG 4zIG8LKxrK7l0Pla3vZjHN/+R6vbAg== =9N9/ -----END PGP SIGNATURE----- --P7YyzzYVLd5ZYWMp--