From: hch <hch@infradead.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: Matthew Wilcox <willy@infradead.org>, david <david@fromorbit.com>,
djwong <djwong@kernel.org>, fgheet255t <fgheet255t@gmail.com>,
hch <hch@infradead.org>, linux-ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
riteshh <riteshh@linux.ibm.com>,
syzbot+a8e049cd3abd342936b6
<syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [syzbot] WARNING in iomap_iter
Date: Sat, 20 Aug 2022 23:29:05 -0700 [thread overview]
Message-ID: <YwHQsbH/aYtH5pVs@infradead.org> (raw)
In-Reply-To: <182b18b5d92.7a2e2b1623166.1514589417142553905@siddh.me>
On Thu, Aug 18, 2022 at 08:51:16PM +0530, Siddh Raman Pant wrote:
> On Thu, 18 Aug 2022 20:20:02 +0530 Matthew Wilcox wrote:
> > I don't think changing these from u64 to s64 is the right way to go.
>
> Why do you think so? Is there somnething I overlooked?
>
> I think it won't intorduce regression, since if something is working,
> it will continue to work. If something does break, then they were
> relying on overflows, which is anyways an incorrect way to go about.
Well, for example userspace code expecting unsignedness of these
types could break. So if we really think changing the types is so
much preferred we'd need to audit common userspace first. Because
of that I think the version proposed by willy is generally preferred.
> Also, it seems even the 32-bit compatibility structure uses signed
> types.
We should probably fix that as well.
next prev parent reply other threads:[~2022-08-21 6:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 23:46 syzbot
2021-11-09 7:20 ` Christoph Hellwig
2022-02-12 20:41 ` syzbot
2022-02-13 14:34 ` Ritesh Harjani
2022-02-14 2:58 ` Dave Chinner
2022-08-18 11:00 ` Siddh Raman Pant
2022-08-18 11:11 ` Siddh Raman Pant
2022-08-18 14:50 ` Matthew Wilcox
2022-08-18 15:21 ` Siddh Raman Pant
2022-08-21 6:29 ` hch [this message]
2022-08-21 11:27 ` Siddh Raman Pant
2022-08-21 11:48 ` Siddh Raman Pant
2022-08-21 20:59 ` syzbot
2022-08-22 14:45 ` Matthew Wilcox
2022-08-22 14:49 ` Siddh Raman Pant
2022-08-22 14:52 ` Matthew Wilcox
2022-08-22 15:02 ` Siddh Raman Pant
2022-08-23 15:21 ` Siddh Raman Pant
2022-08-23 15:28 ` Matthew Wilcox
2022-08-23 15:35 ` Siddh Raman Pant
2022-08-23 15:42 ` Matthew Wilcox
2022-08-23 15:54 ` syzbot
2022-08-23 15:38 ` syzbot
2022-08-18 19:30 ` syzbot
2022-08-18 19:09 ` syzbot
2022-11-14 11:50 ` Siddh Raman Pant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwHQsbH/aYtH5pVs@infradead.org \
--to=hch@infradead.org \
--cc=code@siddh.me \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fgheet255t@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®