From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF68C32772 for ; Mon, 22 Aug 2022 13:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234446AbiHVNDC (ORCPT ); Mon, 22 Aug 2022 09:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbiHVNC7 (ORCPT ); Mon, 22 Aug 2022 09:02:59 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35FAA356D1; Mon, 22 Aug 2022 06:02:59 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 40B082B3; Mon, 22 Aug 2022 15:02:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661173377; bh=3KUAM+O8TZK6k0R26rf5Rv/fs3CP6Usaeb49tMIg+sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Td0g3pwLBnD4ckmy1hbXDW04i7ernfNgHGZCUdSMCtSjlY3Pn1sNUuAGLtBC48rgG FTTZrBGWXPZp5syugBjLfT+n7fp8i1q1BeoXTtDvEUdtHXhb0aXT+mUzYbtYJ7Nhwu /f9Qm6RMTvMXBTYpXVx1XaeYw5BwFMnZT+C6TWvs= Date: Mon, 22 Aug 2022 16:02:53 +0300 From: Laurent Pinchart To: Ricardo Ribalda Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: uvcvideo: Fix InterfaceProtocol for Quanta camera Message-ID: References: <20220808134106.70100-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220808134106.70100-1-ribalda@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Thank you for the patch. On Mon, Aug 08, 2022 at 03:41:06PM +0200, Ricardo Ribalda wrote: > The device is using a different InterfaceProtocol than the one set in > the original quirk. > > Fixes: 95f03d973478 ("media: uvcvideo: Limit power line control for Quanta cameras") > Signed-off-by: Ricardo Ribalda > --- > > This was fixed on the last version of the patchset. Unfortunately I did > checked that it was the version merged :(. Oops :-( > It is too late to land it in this version? I think it can be considered as a v6.0 fix, yes. > drivers/media/usb/uvc/uvc_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 9c05776f11d1..6556158a8888 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2740,7 +2740,7 @@ static const struct usb_device_id uvc_ids[] = { > .idProduct = 0x4034, > .bInterfaceClass = USB_CLASS_VIDEO, > .bInterfaceSubClass = 1, > - .bInterfaceProtocol = 0, > + .bInterfaceProtocol = 1, Should we use UVC_PC_PROTOCOL_15 here ? Reviewed-by: Laurent Pinchart > .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, > /* LogiLink Wireless Webcam */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE -- Regards, Laurent Pinchart