From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7839C32796 for ; Mon, 22 Aug 2022 09:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234530AbiHVJ5E (ORCPT ); Mon, 22 Aug 2022 05:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234569AbiHVJ5A (ORCPT ); Mon, 22 Aug 2022 05:57:00 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E199731DC4; Mon, 22 Aug 2022 02:56:59 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5133E2B3; Mon, 22 Aug 2022 11:56:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661162218; bh=HItqUbPown0MuVwTPfUbAILw8/+d0rHi9wXNaFSpNjk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cbRlKX8k5Pg7aVgZ0GrNQACjH1DxMaf1YWnwExaQWkjyXscljXgOV2PsWaI15NyEe XHnaZcGkMZd/p9RkunmCGx2S2tQPmWjTK1bsTnkOghrs1e3Fxt/gy1F0YQaehyHh2j xCKwBaAa13IALeex34cpG/R2iIrjTsZkrBQttY1k= Date: Mon, 22 Aug 2022 12:56:54 +0300 From: Laurent Pinchart To: Christophe JAILLET Cc: Xavier Roumegue , Mauro Carvalho Chehab , Ezequiel Garcia , Hans Verkuil , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] media: dw100: Fix an error handling path in dw100_probe() Message-ID: References: <7213b90d0d872be154cff81aec1ad8a4a77116af.1661161223.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7213b90d0d872be154cff81aec1ad8a4a77116af.1661161223.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christophe, Thank you for the patch. On Mon, Aug 22, 2022 at 11:40:43AM +0200, Christophe JAILLET wrote: > After a successful call to media_device_init() it is safer to call > media_device_init(). I assume you meant media_device_cleanup() ? With this fixed, Reviewed-by: Laurent Pinchart > Add the missing call in the error handling path of the probe, as already > done in the remove function. > > Fixes: bd090d4d995a ("media: dw100: Add i.MX8MP dw100 dewarper driver") > Signed-off-by: Christophe JAILLET > --- > drivers/media/platform/nxp/dw100/dw100.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c > index 94518f0e486b..b3b057798ab6 100644 > --- a/drivers/media/platform/nxp/dw100/dw100.c > +++ b/drivers/media/platform/nxp/dw100/dw100.c > @@ -1623,6 +1623,7 @@ static int dw100_probe(struct platform_device *pdev) > error_v4l2: > video_unregister_device(vfd); > err_m2m: > + media_device_cleanup(&dw_dev->mdev); > v4l2_m2m_release(dw_dev->m2m_dev); > err_v4l2: > v4l2_device_unregister(&dw_dev->v4l2_dev); -- Regards, Laurent Pinchart