mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jing-Ting Wu <Jing-Ting.Wu@mediatek.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
	"Zefan Li" <lizefan.x@bytedance.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Jonathan.JMChen@mediatek.com, Lixiong.Liu@mediatek.com,
	wsd_upstream@mediatek.com, Wenju.Xu@mediatek.com,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/1] cgroup: Fix race condition at rebind_subsystems()
Date: Tue, 23 Aug 2022 08:12:12 -1000	[thread overview]
Message-ID: <YwUYfNEVIOyQXP8d@slm.duckdns.org> (raw)
In-Reply-To: <20220823054148.29346-1-Jing-Ting.Wu@mediatek.com>

On Tue, Aug 23, 2022 at 01:41:46PM +0800, Jing-Ting Wu wrote:
> Root cause:
> The rebind_subsystems() is no lock held when move css object from A
> list to B list,then let B's head be treated as css node at
> list_for_each_entry_rcu().
> 
> Solution:
> Add grace period before invalidating the removed rstat_css_node.
> 
> Reported-by: Jing-Ting Wu <jing-ting.wu@mediatek.com>
> Suggested-by: Michal Koutný <mkoutny@suse.com>
> Signed-off-by: Jing-Ting Wu <jing-ting.wu@mediatek.com>
> Tested-by: Jing-Ting Wu <jing-ting.wu@mediatek.com>
> Link: https://lore.kernel.org/linux-arm-kernel/d8f0bc5e2fb6ed259f9334c83279b4c011283c41.camel@mediatek.com/T/

Applied to cgroup/for-6.0-fixes w/ stable tag added.

Thanks.

-- 
tejun

  parent reply	other threads:[~2022-08-23 19:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  5:41 Jing-Ting Wu
2022-08-23  7:33 ` Mukesh Ojha
2022-08-23 18:12 ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-23  5:09 Jing-Ting Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwUYfNEVIOyQXP8d@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=Jing-Ting.Wu@mediatek.com \
    --cc=Jonathan.JMChen@mediatek.com \
    --cc=Lixiong.Liu@mediatek.com \
    --cc=Wenju.Xu@mediatek.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lizefan.x@bytedance.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mkoutny@suse.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®