From: Mark Brown <broonie@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andrew Halaney <ahalaney@redhat.com>,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH] regulator: core: Require regulator drivers to check uV for get_optimum_mode()
Date: Tue, 23 Aug 2022 23:49:35 +0100 [thread overview]
Message-ID: <YwVZfyDflFuzFAOX@sirena.org.uk> (raw)
In-Reply-To: <CAD=FV=WSSrObW2PthmUL+t=VYJ+mN6Z763pozCQDbOdPtAXyQA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 630 bytes --]
On Tue, Aug 23, 2022 at 03:32:44PM -0700, Doug Anderson wrote:
> I guess maybe we could add the "initial mode" as an implicitly allowed
> mode? I guess the other option is to implicitly disable
> regulator-allow-set-load if no allowed modes are listed? Both of these
We should do the former, or equivalently just noop out of set_load() via
set_optimium_mode() if no modes are allowed.
> I guess the other option would be to say that if
> "regulator-allow-set-load" is set but not "regulator-allowed-modes"
> then we allow all modes? Somehow that doesn't seem like the "safest"
> option, though.
Yes, I'd prefer to avoid that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-23 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 20:16 Douglas Anderson
2022-08-23 22:14 ` Andrew Halaney
2022-08-23 22:32 ` Doug Anderson
2022-08-23 22:49 ` Mark Brown [this message]
2022-08-24 21:24 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwVZfyDflFuzFAOX@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ahalaney@redhat.com \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®