From: Andrew Lunn <andrew@lunn.ch>
To: Suman Ghosh <sumang@marvell.com>
Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH] octeontx2-pf: Add egress PFC support
Date: Wed, 24 Aug 2022 14:33:38 +0200 [thread overview]
Message-ID: <YwYaoqiS/0+N1TU0@lunn.ch> (raw)
In-Reply-To: <SJ0PR18MB52165D5FA51E433CAD0E8CBBDB739@SJ0PR18MB5216.namprd18.prod.outlook.com>
> >> - schq = hw->txschq_list[lvl][0];
> >> +#ifdef CONFIG_DCB
> >> + if (txschq_for_pfc)
> >> + schq = pfvf->pfc_schq_list[lvl][prio];
> >> + else
> >> +#endif
> >
> >Please could you try to remove as many of these #ifdef CONFIG_DCB as
> >possible. It makes build testing less efficient at finding build
> >problems. Can you do:
> >
> >> + if (IS_ENABLED(CONFIG_DCB) && txschq_for_pfc)
> >> + schq = pfvf->pfc_schq_list[lvl][prio];
> >
> [Suman] I will restructured the code. But we cannot use pfvf->pfc_schq_list outside #ifdef CONFIG_DCB as these are defined under the
> macro in otx2_common.h
So maybe add a getter and setter in otx2_common.h, which returns
-EOPNOTSUPP or similar when CONFIG_DCB is disabled?
Andrew
next prev parent reply other threads:[~2022-08-24 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 6:58 Suman Ghosh
2022-08-23 15:50 ` Andrew Lunn
2022-08-24 5:57 ` [EXT] " Suman Ghosh
2022-08-24 12:33 ` Andrew Lunn [this message]
2022-08-24 12:46 ` Suman Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwYaoqiS/0+N1TU0@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®