From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E0FC04AA5 for ; Thu, 25 Aug 2022 08:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234071AbiHYIvA (ORCPT ); Thu, 25 Aug 2022 04:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236548AbiHYIu4 (ORCPT ); Thu, 25 Aug 2022 04:50:56 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEAE3A8306; Thu, 25 Aug 2022 01:50:53 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oR8Zc-00Exmc-5d; Thu, 25 Aug 2022 18:50:49 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 25 Aug 2022 16:50:48 +0800 Date: Thu, 25 Aug 2022 16:50:48 +0800 From: Herbert Xu To: Gaosheng Cui Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select Message-ID: References: <20220825084138.1881954-1-cuigaosheng1@huawei.com> <20220825084138.1881954-3-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825084138.1881954-3-cuigaosheng1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 04:41:38PM +0800, Gaosheng Cui wrote: > The CRYPTO_CRC32C is using functions provided by CRYPTO_MANAGER, > otherwise the following error will occur: > > EXT4-fs (mmcblk0): Cannot load crc32c driver. > > So select CRYPTO_MANAGER when enable CRYPTO_CRC32C. > > Signed-off-by: Gaosheng Cui > --- > crypto/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index b1ccf873779d..7f124604323b 100644 > --- a/crypto/Kconfig > +++ b/crypto/Kconfig > @@ -641,6 +641,7 @@ config CRYPTO_CRC32C > tristate "CRC32c CRC algorithm" > select CRYPTO_HASH > select CRC32 > + select CRYPTO_MANAGER > help > Castagnoli, et al Cyclic Redundancy-Check Algorithm. Used > by iSCSI for header and data digests and by others. Why exactly does it need CRYPTO_MANAGER? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt