From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7628CC04AA5 for ; Thu, 25 Aug 2022 11:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241002AbiHYLqj (ORCPT ); Thu, 25 Aug 2022 07:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbiHYLqh (ORCPT ); Thu, 25 Aug 2022 07:46:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB9A726A9 for ; Thu, 25 Aug 2022 04:46:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F145761AFB for ; Thu, 25 Aug 2022 11:46:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF1C1C433C1; Thu, 25 Aug 2022 11:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661427994; bh=NrgS14/1+nnvwPDg6upUH+2/MCwbqlv3Q7qDD7G3Q8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LqS15n42zZFNeA4mVCyap5yqd8zWGbkPD2RXc9Qyx9VRcbu5k4yS3ouKu0RCnFQfM rbGVkmm+/l1yyRG5AWm4ouasCWTPONE4B6np/VqE6zHPBZDPcpzEkbuYSfOT2x6hoi SeJe7JiLHMFflwI9C7jO3vK4Ld78oWs82Jc3iOGE= Date: Thu, 25 Aug 2022 13:46:31 +0200 From: Greg Kroah-Hartman To: "Czerwacki, Eial" Cc: "linux-kernel@vger.kernel.org" , "Arsh, Leonid" , "Twaig, Oren" , SAP vSMP Linux Maintainer , Arnd Bergmann , Dan Carpenter , Andra Paraschiv , Borislav Petkov , Brijesh Singh , Eric Biggers , Fei Li , Hans de Goede , Jens Axboe , Mauro Carvalho Chehab Subject: Re: [PATCH v2] drivers/virt/vSMP: new driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 10:41:28AM +0000, Czerwacki, Eial wrote: > >On Thu, Aug 25, 2022 at 10:16:59AM +0000, Czerwacki, Eial wrote: > >> >> >And why is your version file a binary file?  It should just be a small > >> >> >text string, right? > >> >> not so small, it can reach up to 512kb. > >> > > >> >That was not obvious at all.  Please document this. > >> where should the document be? > >> in the code as a comment or in another file? > > > >In the Documentation/ABI/ file that describes this file. > ok, will place it there > > > > >> >And how in the world is a "version" that big?  What exactly does this > >> >contain? > >> it 's size depends on the number of resources it uses. > >> here is an example: > >> :~> cat /sys/hypervisor/vsmp/version  > >> SAP vSMP Foundation: 10.6.2862.0 (Aug 22 2022 15:21:02) > >> System configuration: > >>    Boards:      2 > >>       1 x Proc. + I/O + Memory > >>       1 x NVM devices (Amazon.com Amazon EC2 NVMe Instance Storage) > >>    Processors:  1, Cores: 2, Threads: 4 > >>        Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz Stepping 04 > >>    Memory (MB): 30976 (of 103192), Cache: 7527, Private: 64689 > >>       1 x  6400MB    [ 7825/ 321/ 1104]      > >>       1 x 24576MB    [95367/7206/63585]       00:1f.0#1 > >>    Boot device: [HDD] NVMe: Amazon Elastic Block Store        > >> Supported until: Aug 22 2024 > > > >That is crazy, and is not a version.  It's a "configuration". > it is called version for history reasons... There is no "history" here, you can create whatever sane interface you want right now, there is no backwards compatible issues involved at all. > >See above, make it text only for the version.  If you want to export > >other things, be explicit and make them "one value per sysfs file" or > >use debugfs for debugging things that no one relies on. > so you suggest braking the summery into files, e.g. one for cpus, one for ram and etcetera? Again, who uses this information and what is it used for? thanks, greg k-h