From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7279ECAAD4 for ; Fri, 26 Aug 2022 13:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343706AbiHZNMB (ORCPT ); Fri, 26 Aug 2022 09:12:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbiHZNL7 (ORCPT ); Fri, 26 Aug 2022 09:11:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE343A2DAC; Fri, 26 Aug 2022 06:11:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67BF561D49; Fri, 26 Aug 2022 13:11:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADAD7C433C1; Fri, 26 Aug 2022 13:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661519517; bh=QQoUPSHqx5rAL5i+Fp7jqIcmWyRc9Uc4L6KZPpl4oys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pekQ1JJbaiyxjSHHbpz3EHPezpq7Wj00xt2jIS20NToeASW56PR1ztNrDktEk6kTy 93BiAQpcQztfV7IbJU8ceeRmwD02HWy675BAYXbv2SpVB8NToKDGRpZjFlrgEYjzpy UsxsCNhQRx/NYbkHrSspjCeeTwqC2biw+USvHmf7w6y7zHYn10Xy955iK9iceuqiAO 7uPDbMbGDJyLedQ0Jfle8/7/yHUmFnzINELc/vFGXLE5s3paqbx8txUCFIHbLH78UZ iZQE5hopUDJ2jA5c+zMn+onwTdRXMXIWnO5tovF+Ubv4totQN+L6hrBE7+4CkPZe4Q hjjVehQelYekw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oRZ81-0005zC-La; Fri, 26 Aug 2022 15:12:06 +0200 Date: Fri, 26 Aug 2022 15:12:05 +0200 From: Johan Hovold To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, Johan Hovold , Douglas Anderson , Krishna Kurapati , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH 2/2] clk: qcom: gcc-sc7280: Keep USB GDSC power domains on when USB wakeup is enabled Message-ID: References: <20220822115246.1.I45235b7c40997bc2abf813e4722b4dcdd6aecf6b@changeid> <20220822115246.2.If09027f73daa6e1ed95f5eab02326b543c67132e@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 06:05:19AM -0700, Matthias Kaehlcke wrote: > On Thu, Aug 25, 2022 at 03:16:58PM -0700, Matthias Kaehlcke wrote: > > On Wed, Aug 24, 2022 at 10:47:44AM +0200, Johan Hovold wrote: > > > The wakeup setting doesn't seem to have anything to do with the genpd > > > issues on sc8280xp and the controller doesn't resume properly regardless > > > of whether the PHYs have been disabled or not during suspend unless the > > > PD is left on. > > > > I'm essentially seeing the same. USB is hosed after resume unless the PD > > is left on. > > > > On Chrome OS we currently work around that with a version of commit > > d9be8d5c5b03 ("usb: dwc3: qcom: Keep power domain on to retain controller > > status") which was reverted upstream. I'm not sure whether USB worked after > > resume before we enabled wakeup support. I would have sworn it did, but we > > landed an old version of the wakeup patches a long time ago, so my > > memory might be failing me. > > I need to remind myself that keeping the GDSC on is only needed when the PHYs > are kept on. The PHYs were always off before wakeup support was added, which > is why USB wasn't broken after suspend in the pre-wakeup days. Ok, so to be clear: if you disable wakeup with my patches applied so that the PD is actually turned off, USB still resumes with only GENPD_FLAG_ACTIVE_WAKEUP set? That is, you don't need to set ALWAYS_ON as I do with sc8280xp? Johan