From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6B0ECAAD4 for ; Mon, 29 Aug 2022 09:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229741AbiH2JRT (ORCPT ); Mon, 29 Aug 2022 05:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiH2JRQ (ORCPT ); Mon, 29 Aug 2022 05:17:16 -0400 Received: from mail.thorsis.com (mail.thorsis.com [92.198.35.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C1275AA07 for ; Mon, 29 Aug 2022 02:17:14 -0700 (PDT) Date: Mon, 29 Aug 2022 11:17:05 +0200 From: Alexander Dahl To: Olliver Schinagl Cc: Rob Herring , Krzysztof Kozlowski , Jacek Anaszewski , Baolin Wang , Daniel Mack , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields , Olliver Schinagl , devicetree@vger.kernel.org, linux-kernel Subject: Re: [PATCH v2] dt-bindings: leds: Expand LED_COLOR_ID definitions Message-ID: Mail-Followup-To: Olliver Schinagl , Rob Herring , Krzysztof Kozlowski , Jacek Anaszewski , Baolin Wang , Daniel Mack , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields , Olliver Schinagl , devicetree@vger.kernel.org, linux-kernel References: <7c688821-140b-4b05-651b-337f602dc1fe@schinagl.nl> <6ec9eaa1-2bc2-a32f-6685-4a2a645a5a59@schinagl.nl> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6ec9eaa1-2bc2-a32f-6685-4a2a645a5a59@schinagl.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Olliver, Am Fri, Aug 12, 2022 at 04:31:55PM +0200 schrieb Olliver Schinagl: > In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions, > > Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where > added. However, there's a little more very common LED colors. > > While the documentation states 'add what is missing', engineers tend to > be lazy and will just use what currently exists. So this patch will take > (a) list from online retailers [0], [1], [2] and use the common LED colors > from > there, this being reasonable as this is what is currently available to > purchase. > > Note, that LIME seems to be the modern take to 'Yellow-green' or > 'Yellowish-green' from some older datasheets. > > [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125 > [1]: https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-leds-smd > [2]: https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standard-single-colour-leds-under-75ma > > Signed-off-by: Olliver Schinagl > --- > > Changes since v1: Unbreak existing definitions. > >  include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------ >  1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/include/dt-bindings/leds/common.h > b/include/dt-bindings/leds/common.h > index 3be89a7c20a9..04bf94523ea3 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -22,18 +22,22 @@ >  #define LEDS_BOOST_FIXED    2 > >  /* Standard LED colors */ > -#define LED_COLOR_ID_WHITE    0 > -#define LED_COLOR_ID_RED    1 > -#define LED_COLOR_ID_GREEN    2 > -#define LED_COLOR_ID_BLUE    3 > -#define LED_COLOR_ID_AMBER    4 > -#define LED_COLOR_ID_VIOLET    5 > -#define LED_COLOR_ID_YELLOW    6 > -#define LED_COLOR_ID_IR        7 > -#define LED_COLOR_ID_MULTI    8    /* For multicolor LEDs */ > -#define LED_COLOR_ID_RGB    9    /* For multicolor LEDs that can do > arbitrary color, > -                       so this would include RGBW and similar */ > -#define LED_COLOR_ID_MAX    10 > +#define LED_COLOR_ID_WHITE      0 > +#define LED_COLOR_ID_RED        1 > +#define LED_COLOR_ID_GREEN      2 > +#define LED_COLOR_ID_BLUE       3 > +#define LED_COLOR_ID_AMBER      4 > +#define LED_COLOR_ID_VIOLET     5 > +#define LED_COLOR_ID_YELLOW     6 > +#define LED_COLOR_ID_IR         7 > +#define LED_COLOR_ID_MULTI      8 /* For multicolor LEDs */ > +#define LED_COLOR_ID_RGB        9 /* For multicolor LEDs that can do > arbitrary color, including RGBW etc. */ > +#define LED_COLOR_ID_PUPRPLE   10 Typo? Should be LED_COLOR_ID_PURPLE, right? Greets Alex > +#define LED_COLOR_ID_ORANGE    11 > +#define LED_COLOR_ID_PINK      12 > +#define LED_COLOR_ID_CYAN      13 > +#define LED_COLOR_ID_LIME      14 > +#define LED_COLOR_ID_MAX       15 > >  /* Standard LED functions */ >  /* Keyboard LEDs, usually it would be input4::capslock etc. */ > -- > 2.37.1 >