From: Jules Irenge <jbi.octave@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: Add missing annotation for iput_final()
Date: Sun, 11 Sep 2022 15:05:07 +0100 [thread overview]
Message-ID: <Yx3rE3zkN7p8/Znz@playground> (raw)
Sparse reports a warning at iput_final()
warning: context imbalance in iput_final - unexpected unlock
The root cause is the missing annotation at iput_final()
Add the missing __releases(&inode->i_lock) annotation
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
fs/inode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/inode.c b/fs/inode.c
index ba1de23c13c1..a1dd9a976add 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1706,6 +1706,7 @@ EXPORT_SYMBOL(generic_delete_inode);
* shutting down.
*/
static void iput_final(struct inode *inode)
+ __releases(&inode->i_lock)
{
struct super_block *sb = inode->i_sb;
const struct super_operations *op = inode->i_sb->s_op;
--
2.35.1
reply other threads:[~2022-09-11 14:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx3rE3zkN7p8/Znz@playground \
--to=jbi.octave@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®