From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4ADFECAAD3 for ; Mon, 12 Sep 2022 01:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbiILBZc (ORCPT ); Sun, 11 Sep 2022 21:25:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiILBZ3 (ORCPT ); Sun, 11 Sep 2022 21:25:29 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E25FE175AB for ; Sun, 11 Sep 2022 18:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662945928; x=1694481928; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ecU4kyT9//WudYGodoYB0OtJ/Rmk8S4MnM/86WtnIxo=; b=JCyZ8Qd7Td+28qRybz1nX0xiq5DVcWxIhHqEhF6SZD7UpUL7fSmUjEjh ysTp+kcFOnzNTOG9kG40Yxc0wqu2rVb5W72SiEVA96dEuM5Q1jpot0LKX FW6lCrIVyD+L9nxb+WaU95VM6zD+UWA5ZWJtUTDA78MbgtCMZ07XOLots WGKdgeDVuNJjG4cpQDozBmEkkq8srWuqKpVjOETFxRkze9bMmy3AEi+bS W5cETje1ZxHBtjLRKktpfIjve1SQVqoqODEYUqaSOcck5hxmvhThFvVF/ c+VTCmdt6jqDPl5nxV+Qi4jx8+ApGZydZtQ4hDBrPFg/5a07KD4uKz8Oo w==; X-IronPort-AV: E=McAfee;i="6500,9779,10467"; a="278158945" X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="278158945" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2022 18:25:28 -0700 X-IronPort-AV: E=Sophos;i="5.93,308,1654585200"; d="scan'208";a="646261125" Received: from dasegal-mobl.amr.corp.intel.com (HELO intel.com) ([10.249.46.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2022 18:25:24 -0700 Date: Mon, 12 Sep 2022 03:25:21 +0200 From: Andi Shyti To: Mauro Carvalho Chehab Cc: Rodrigo Vivi , Thomas =?iso-8859-15?Q?Hellstr=F6m?= , Andi Shyti , Chris Wilson , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Matthew Auld , Tvrtko Ursulin , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 33/37] drm/i915 i915_gem_object_types.h: document struct i915_lut_handle Message-ID: References: <0da7c28a377a1fac9db524dbc8462731d922b39c.1662708705.git.mchehab@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0da7c28a377a1fac9db524dbc8462731d922b39c.1662708705.git.mchehab@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Fri, Sep 09, 2022 at 09:34:40AM +0200, Mauro Carvalho Chehab wrote: > commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr") > added a rbtree list to allow searching for obj/ctx. > > Document it. > > Reviewed-by: Rodrigo Vivi > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v3 00/37] at: https://lore.kernel.org/all/cover.1662708705.git.mchehab@kernel.org/ > > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > index 9f6b14ec189a..35746cf268ea 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > @@ -21,9 +21,15 @@ struct drm_i915_gem_object; > struct intel_fronbuffer; > struct intel_memory_region; > > -/* > - * struct i915_lut_handle tracks the fast lookups from handle to vma used > - * for execbuf. Although we use a radixtree for that mapping, in order to > +/** > + * struct i915_lut_handle - tracks the fast lookups from handle to vma used > + * for execbuf. > + * just to be picky: do we or don't we want this extra space here? I think that besides our personal taste it's important to have a coherent style. I would r-b it anyway if I didn't look the next patch. Andi > + * @obj_link: link to the object associated with the @handle. > + * @ctx: context associated with the @handle. > + * @handle: a rbtree handle to lookup context for specific obj/vma. > + * > + * Although we use a radixtree for that mapping, in order to > * remove them as the object or context is closed, we need a secondary list > * and a translation entry (i915_lut_handle). > */ > -- > 2.37.3