From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable-5.10] arm64: errata: add detection for AMEVCNTR01 incrementing incorrectly
Date: Mon, 12 Sep 2022 16:41:45 +0200 [thread overview]
Message-ID: <Yx9FKf1Fxl4LwW4G@kroah.com> (raw)
In-Reply-To: <20220912135226.31027-1-ionela.voinescu@arm.com>
On Mon, Sep 12, 2022 at 02:52:26PM +0100, Ionela Voinescu wrote:
> commit e89d120c4b720e232cc6a94f0fcbd59c15d41489 upstream.
>
> The AMU counter AMEVCNTR01 (constant counter) should increment at the same
> rate as the system counter. On affected Cortex-A510 cores, AMEVCNTR01
> increments incorrectly giving a significantly higher output value. This
> results in inaccurate task scheduler utilization tracking.
>
> Work around this problem by keeping the reference values of affected
> counters to 0. This results in disabling the single user of this
> counter: Frequency Invariance Engine (FIE).
> This effect is the same to firmware disabling affected counters, in
> which case 0 will be returned when reading the disabled counters.
>
> Therefore, AMU counters will not be used for frequency invariance for
> affected CPUs and CPUs in the same cpufreq policy. AMUs can still be used
> for frequency invariance for unaffected CPUs in the system.
>
> The above is achieved through adding a new erratum: ARM64_ERRATUM_2457168.
>
> Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: James Morse <james.morse@arm.com>
> Link: https://lore.kernel.org/r/20220819103050.24211-1-ionela.voinescu@arm.com
> ---
>
> Hi,
>
> This is a backport to stable 5.10.142 of the upstream commit
> e89d120c4b72 arm64: errata: add detection for AMEVCNTR01 incrementing incorrectly
>
> This is sent separately as there were conflicts that needed resolving
> when applying the mainline patch. Compared to the upstream version this
> no longer handles the FFH usecase, as FFH support is not present in 5.10.
> Therefore the commit message and Kconfig description are modified to
> only describe the effect on FIE caused by this erratum.
Both backports now queued up, thanks.
greg k-h
prev parent reply other threads:[~2022-09-12 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 13:52 Ionela Voinescu
2022-09-12 14:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx9FKf1Fxl4LwW4G@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®