From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A724EECAAD1 for ; Thu, 1 Sep 2022 10:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232332AbiIAKEx (ORCPT ); Thu, 1 Sep 2022 06:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbiIAKEt (ORCPT ); Thu, 1 Sep 2022 06:04:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A8DD137DBF for ; Thu, 1 Sep 2022 03:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=E7Pj8d93m0JiiJeXTEUQOcUvv07HLnIlWqZMHnp6uuM=; b=kHEuwZ6PlHxiap9evj2L/urMpc ya4JvUiTYGruZzelyyjd7L2g6dsff1EqfgXm4BBHNqZmvwmvEoDFBp0S/PqwQs/h7zPbdVQmE2NqJ gb8dEPR64uBsKjVSaMpbQxxYX0sL570bkRsWdM2KBfkZKCzy9icNXNnIZvXI43KWOJO3VznaW3brS LXlVFkjyLatG9neCk87YZJwnTFIRCECXdlbNUaE/YbM9+kpTqUV4l/cqFvt6aI9+n8gVOhzV5jM84 5QN2uP6NtCj6PR9DC4mNfySMRLwLtTB3w0LH6+FchGgn4rEZexRwUER527OxGnsodNZapMjxZRgwX 4ibjfEng==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTh3q-005w82-Vo; Thu, 01 Sep 2022 10:04:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 19F993002C7; Thu, 1 Sep 2022 12:04:32 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id F30502B85513D; Thu, 1 Sep 2022 12:04:31 +0200 (CEST) Date: Thu, 1 Sep 2022 12:04:31 +0200 From: Peter Zijlstra To: "Liang, Kan" Cc: x86@kernel.org, eranian@google.com, ravi.bangoria@amd.com, linux-kernel@vger.kernel.org, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org Subject: Re: [PATCH v2 8/9] perf/x86/intel: Shadow MSR_ARCH_PERFMON_FIXED_CTR_CTRL Message-ID: References: <20220829100959.917169441@infradead.org> <20220829101321.905673933@infradead.org> <0b8477e2-6e85-b349-0e92-e6a298531c18@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2022 at 11:10:49AM +0200, Peter Zijlstra wrote: > On Wed, Aug 31, 2022 at 09:52:19AM -0400, Liang, Kan wrote: > > > > > > On 2022-08-29 6:10 a.m., Peter Zijlstra wrote: > > > Less RDMSR is more better. > > > > I had an RFC patch which does a further step to move the fixed > > control register write to right before the entire PMU re-enabling, which > > could also save some writes if there are several fixed counters enabled. > > https://lore.kernel.org/lkml/20220804140729.2951259-1-kan.liang@linux.intel.com/ > > > > Do you have any comments for the RFC patch? > > > > Oh, I like that better, let me just replace my patch with that. git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/wip.cleanup Should have your patch instead of mine for the FIXED_CTR_CTRL and have the pmu methods in the right place.