From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D5CC6FA82 for ; Fri, 2 Sep 2022 20:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbiIBUaY (ORCPT ); Fri, 2 Sep 2022 16:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbiIBUaT (ORCPT ); Fri, 2 Sep 2022 16:30:19 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52A7C63F24; Fri, 2 Sep 2022 13:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=6jN31VgQCCRw0E2mRT8jomR23ac2A5p7CJG0IlzW8UU=; b=Y/50yDLE6u8Ow435onwJCh+W40 P/1T+18ej3hVxzr+xXrhq90lL9CBKEo6IacYzj51L8O5Z4xCyfy6SGViQnQH2RTPJPAfDDEvQKLY3 TDFdgIC/hdFwI+FfrpkdKwRci+sHnB2cfZnc4nS+fltjA9eomaCRzDqhTEQpaySjQnQE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oUDIZ-00FR3g-JQ; Fri, 02 Sep 2022 22:29:55 +0200 Date: Fri, 2 Sep 2022 22:29:55 +0200 From: Andrew Lunn To: Jerry.Ray@microchip.com Cc: vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: dsa: LAN9303: Add basic support for LAN9354 Message-ID: References: <20220829180037.31078-1-jerry.ray@microchip.com> <20220829180037.31078-2-jerry.ray@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >Please validate that what you find on the board actually is what the compatible says it should be. If you don't validate it, there will be some DT blobs that have the wrong value, but probe fine. But then you cannot actually make use of the compatible string in the driver to do something different between the 9303 and the 9354 because some boards have the wrong compatible.... Please configure your mail client to stop corrupting emails. My reply definitely did not have lines this long. > > > > Andrew > > > > At this time, the driver is meant to support both devices equally. In the future, I will be adding content that only applies to the LAN9354. That is when I'm planning to add .data to the .compatible entries. Which makes it even more important to validate the compatible against what is actually on the board. As i said, in its current state, people are going to get it wrong, and your .data won't work, since it will be for a different chip to which is actually on the board. Andrew