From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284EAC38145 for ; Sat, 3 Sep 2022 01:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbiICB17 (ORCPT ); Fri, 2 Sep 2022 21:27:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230325AbiICB14 (ORCPT ); Fri, 2 Sep 2022 21:27:56 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 28C9FEF026 for ; Fri, 2 Sep 2022 18:27:55 -0700 (PDT) Received: (qmail 289817 invoked by uid 1000); 2 Sep 2022 21:27:54 -0400 Date: Fri, 2 Sep 2022 21:27:54 -0400 From: Alan Stern To: Paul =?iso-8859-1?Q?Heidekr=FCger?= Cc: Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , Joel Fernandes , Michael Ellerman , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Marco Elver , Charalampos Mainas , Pramod Bhatotia , Soham Chakraborty , Martin Fink Subject: Re: [PATCH v3] tools/memory-model: Weaken ctrl dependency definition in explanation.txt Message-ID: References: <20220902211341.2585133-1-paul.heidekrueger@in.tum.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220902211341.2585133-1-paul.heidekrueger@in.tum.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2022 at 09:13:40PM +0000, Paul Heidekrüger wrote: > The current informal control dependency definition in explanation.txt is > too broad and, as discussed, needs to be updated. > > Consider the following example: > > > if(READ_ONCE(x)) > > return 42; > > > > WRITE_ONCE(y, 42); > > > > return 21; > > The read event determines whether the write event will be executed "at all" > - as per the current definition - but the formal LKMM does not recognize > this as a control dependency. > > Introduce a new definition which includes the requirement for the second > memory access event to syntactically lie within the arm of a non-loop > conditional. > > Link: https://lore.kernel.org/all/20220615114330.2573952-1-paul.heidekrueger@in.tum.de/ > Cc: Marco Elver > Cc: Charalampos Mainas > Cc: Pramod Bhatotia > Cc: Soham Chakraborty > Cc: Martin Fink > Signed-off-by: Paul Heidekrüger > Co-developed-by: Alan Stern Signed-off-by: Alan Stern > --- > > v3: > - Address Alan and Joel's feedback re: the wording around switch statements > and the use of "guarding" > > v2: > - Fix typos > - Fix indentation of code snippet > > v1: > @Alan, since I got it wrong the last time, I'm adding you as a co-developer > after my SOB. I'm sorry if this creates extra work on your side due to you > having to resubmit the patch now with your SOB if I understand correctly, > but since it's based on your wording from the other thread, I definitely > wanted to give you credit. > > tools/memory-model/Documentation/explanation.txt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt > index ee819a402b69..0b7e1925a673 100644 > --- a/tools/memory-model/Documentation/explanation.txt > +++ b/tools/memory-model/Documentation/explanation.txt > @@ -464,9 +464,11 @@ to address dependencies, since the address of a location accessed > through a pointer will depend on the value read earlier from that > pointer. > > -Finally, a read event and another memory access event are linked by a > -control dependency if the value obtained by the read affects whether > -the second event is executed at all. Simple example: > +Finally, a read event X and another memory access event Y are linked by > +a control dependency if Y syntactically lies within an arm of an if > +statement and X affects the evaluation of the if condition via a data or > +address dependency (or similarly for a switch statement). Simple > +example: > > int x, y; >