From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96F0C38145 for ; Sat, 3 Sep 2022 05:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231596AbiICFgZ (ORCPT ); Sat, 3 Sep 2022 01:36:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231760AbiICFgW (ORCPT ); Sat, 3 Sep 2022 01:36:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C9A02C64F; Fri, 2 Sep 2022 22:36:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6429609D0; Sat, 3 Sep 2022 05:36:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70DB3C433C1; Sat, 3 Sep 2022 05:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662183381; bh=OpKJfWdrDc3n3wA6yyELGco8XbWwsYE05NA7T35/G2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hv3UQax3zC9KwiMM1HJaOv5cCenbfX3sbxN7smMl4G/+VABgRVil24EXJn7Ho32Cb +ScKqzdQxPZGXOux5Guv75MhbvbZNmu+ISgv7Ob8aQEX2OiTUghk0btQpKrPiysz81 KJaKP+lACKs8DYJdw2+aSzSLI4laZi++O54F71sw= Date: Sat, 3 Sep 2022 07:36:38 +0200 From: Greg KH To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mm/damon/dbgfs: fix memory leak when using Message-ID: References: <20220902191149.112434-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220902191149.112434-1-sj@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 02, 2022 at 07:11:49PM +0000, SeongJae Park wrote: > From: Greg Kroah-Hartman > > debugfs_lookup() > Date: Fri, 2 Sep 2022 14:56:31 +0200 [thread overview] > Message-ID: <20220902125631.128329-1-gregkh@linuxfoundation.org> (raw) > > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. Fix this up by properly > calling dput(). > > Fixes: 75c1c2b53c78b ("mm/damon/dbgfs: support multiple contexts") > Cc: # 5.15.x > Cc: SeongJae Park > Cc: Andrew Morton > Cc: damon@lists.linux.dev > Cc: linux-mm@kvack.org > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Andrew Morton > Signed-off-by: SeongJae Park > --- > Changes from v1 > (https://lore.kernel.org/damon/20220902125631.128329-1-gregkh@linuxfoundation.org/) > - Call dput() for failure-return case (Andrew Morton) Thanks for fixing this up, I missed the other return error cases in my rush to audit the whole tree at once. This version looks great, and I see Andrew has taken it now into his tree, thanks! greg k-h