From: Herbert Xu <herbert@gondor.apana.org.au>
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com,
kernel test robot <lkp@intel.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH v2] crypto: aspeed: fix build module error
Date: Tue, 6 Sep 2022 12:53:19 +0800 [thread overview]
Message-ID: <YxbSPxlOFX3RMLXY@gondor.apana.org.au> (raw)
In-Reply-To: <20220905025433.1610696-1-neal_liu@aspeedtech.com>
On Mon, Sep 05, 2022 at 10:54:33AM +0800, Neal Liu wrote:
> If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m,
> build modpost would be failed.
>
> Error messages:
> ERROR: modpost: "aspeed_register_hace_hash_algs"
> [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!
> ERROR: modpost: "aspeed_unregister_hace_hash_algs"
> [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!
>
> Change build sequence to fix this.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> Tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> v2: Remove redundant obj- lines.
>
> drivers/crypto/aspeed/Makefile | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2022-09-06 4:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 2:54 Neal Liu
2022-09-05 11:04 ` Herbert Xu
2022-09-06 2:21 ` Neal Liu
2022-09-16 10:42 ` Herbert Xu
2022-09-16 17:21 ` Dhananjay Phadke
2022-09-19 6:36 ` Neal Liu
2022-09-06 4:53 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxbSPxlOFX3RMLXY@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neal_liu@aspeedtech.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®