From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Szuying Chen <chensiying21@gmail.com>
Cc: YehezkelShB@gmail.com, gregkh@linuxfoundation.org,
mario.limonciello@amd.com, andreas.noever@gmail.com,
michael.jamet@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw,
Chloe_Chen@asmedia.com.tw, Richard_Hsu@asmedia.com.tw
Subject: Re: [PATCH v9 6/6] thunderbolt: Add support for ASMedia image format
Date: Tue, 6 Sep 2022 13:20:01 +0300 [thread overview]
Message-ID: <Yxce0WshoIgS7zBz@black.fi.intel.com> (raw)
In-Reply-To: <20220906101128.6504-1-chensiying21@gmail.com>
On Tue, Sep 06, 2022 at 06:11:28PM +0800, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@asmedia.com.tw>
>
> Hi,
>
> >
> > +static int asmedia_switch_nvm_version(struct tb_nvm *nvm) {
> > + struct tb_switch *sw = tb_to_switch(nvm->dev);
> > + u32 val;
> > + int ret;
> > +
> > + ret = tb_switch_nvm_read(sw, ASMEDIA_NVM_VERSION, &val, sizeof(val));
> > + if (ret)
> > + return ret;
> > +
> > + nvm->major = (val << 16) & 0xff0000;
> > + nvm->minor |= val & 0x00ff00;
>
> nvm->major
Heh, that one was clearly a copy paste error ;-)
I will fix it up when applying. Thanks for checking.
prev parent reply other threads:[~2022-09-06 10:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 10:11 Szuying Chen
2022-09-06 10:20 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxce0WshoIgS7zBz@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Chloe_Chen@asmedia.com.tw \
--cc=Richard_Hsu@asmedia.com.tw \
--cc=Yd_Tseng@asmedia.com.tw \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=chensiying21@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®