From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Martyn Welch <martyn.welch@collabora.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] gpio: pca953x: Add support for PCAL6534
Date: Tue, 6 Sep 2022 17:28:37 +0300 [thread overview]
Message-ID: <YxdZFRyv5E0qvXgS@smile.fi.intel.com> (raw)
In-Reply-To: <a71dec127a2e188b1eb7df1e385f71410051acca.camel@collabora.com>
On Tue, Sep 06, 2022 at 03:01:51PM +0100, Martyn Welch wrote:
> On Tue, 2022-09-06 at 15:24 +0300, Andy Shevchenko wrote:
> > On Tue, Sep 06, 2022 at 09:28:19AM +0100, Martyn Welch wrote:
...
> > > + u8 (*recalc_addr)(struct pca953x_chip *chip, int reg , int
> > > off);
> > > + bool (*check_reg)(struct pca953x_chip *chip, unsigned int
> > > reg,
> > > + u32 checkbank);
> >
> > I would think of splitting this change. Like in a separate patch you
> > simply
> > create this interface and only add what you need in the next one.
>
> Can do, though I didn't feel you were particularly fussed about me
> having split that out...
Oh, it just would be cleaner to see what you have done for a new chip support.
Up to you and maintainers.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-06 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:28 [PATCH v2 1/5] dt-bindings: vendor-prefixes: add Diodes Martyn Welch
2022-09-06 8:28 ` [PATCH v2 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q Martyn Welch
2022-09-06 8:37 ` Krzysztof Kozlowski
2022-09-06 12:19 ` Andy Shevchenko
2022-09-06 13:08 ` Linus Walleij
2022-09-06 13:19 ` Andy Shevchenko
2022-09-06 13:33 ` Linus Walleij
2022-09-06 13:53 ` Andy Shevchenko
2022-09-06 14:19 ` Rob Herring
2022-09-06 14:31 ` Andy Shevchenko
2022-09-06 13:05 ` Linus Walleij
2022-09-06 13:40 ` Rob Herring
2022-09-06 8:28 ` [PATCH v2 3/5] gpio: pca953x: Fix pca953x_gpio_set_pull_up_down() Martyn Welch
2022-09-06 8:28 ` [PATCH v2 4/5] gpio: pca953x: Swap if statements to save later complexity Martyn Welch
2022-09-06 8:28 ` [PATCH v2 5/5] gpio: pca953x: Add support for PCAL6534 Martyn Welch
2022-09-06 12:24 ` Andy Shevchenko
2022-09-06 14:01 ` Martyn Welch
2022-09-06 14:28 ` Andy Shevchenko [this message]
2022-09-09 13:27 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: add Diodes Bartosz Golaszewski
2022-09-09 13:28 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxdZFRyv5E0qvXgS@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®