From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BE4ECAAD3 for ; Wed, 7 Sep 2022 06:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbiIGGIS (ORCPT ); Wed, 7 Sep 2022 02:08:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiIGGIQ (ORCPT ); Wed, 7 Sep 2022 02:08:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFAFA8D3CE for ; Tue, 6 Sep 2022 23:08:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93933B81AAA for ; Wed, 7 Sep 2022 06:08:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CED4C433C1; Wed, 7 Sep 2022 06:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662530893; bh=54fvH7VDRvsGmh4xj/BwuuP8XcmMrbqIP4PH3zgeTFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KgtAetD9hwCH2h7eUABYqWhstWrcoH/w9y14eL34cVoVRv92lA3Jga4NGwjNLUcvR yOTwQPyUR1Xnfns3DlL3i8Ntt51dqEoqiS9Dr0z6kxLz5aKYZRNkMN+Err7OdYmSzC z3gk0jfg6N5Q8BDp2/Vb+ngQMrAYfNEsHLWG+a/s= Date: Wed, 7 Sep 2022 08:08:08 +0200 From: Greg KH To: Kumaravel.Thiagarajan@microchip.com Cc: lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [char-misc:char-misc-next 21/24] drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be static? Message-ID: References: <202209051441.knwv3o1D-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2022 at 06:02:22PM +0000, Kumaravel.Thiagarajan@microchip.com wrote: > > -----Original Message----- > > From: kernel test robot > > Sent: Monday, September 5, 2022 12:07 PM > > To: Kumaravel Thiagarajan - I21417 > > Cc: kbuild-all@lists.01.org; linux-kernel@vger.kernel.org; Greg Kroah- > > Hartman > > Subject: [char-misc:char-misc-next 21/24] > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: sparse: > > symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it be > > static? > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > > char-misc-next > > head: 50e177c5bfd9abc3828cb57e14e6169170f6764a > > commit: 7d3e4d807df2a216b9aa2944372f2b3f6ef3f205 [21/24] misc: > > microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device > > enumerated by the auxiliary bus driver. > > config: i386-randconfig-s033-20220905 > > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 > . > . > . > > > > sparse warnings: (new ones prefixed by >>) > > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:135:34: sparse: > > sparse: symbol 'pci1xxxx_gpio_auxiliary_id_table' was not declared. Should it > > be static? > Greg, do I need to submit another patch to resolve this warning on char-misc-next? > I did not combine this with the last patch thinking that the last patch would > be merged with the commit that introduced the errors and not queued. No, I can't merge it into an older commit as those branches can never be rebased. Please send a new fix for this issue as well. thanks, greg k-h