From: Tejun Heo <tj@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] cgroup/cpuset: remove unreachable code
Date: Wed, 7 Sep 2022 05:32:16 -1000 [thread overview]
Message-ID: <Yxi5gI1f2MxdC0c9@slm.duckdns.org> (raw)
In-Reply-To: <20220907040112.82030-1-jiapeng.chong@linux.alibaba.com>
(cc'ing Waiman and quoting the whole message)
On Wed, Sep 07, 2022 at 12:01:12PM +0800, Jiapeng Chong wrote:
> The function sched_partition_show cannot execute seq_puts, delete the
> invalid code.
>
> kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
Applied to cgroup/for-6.1.
Thanks.
> kernel/cgroup/cpuset.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 6baa977a71ba..b474289c15b8 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
> else
> seq_printf(seq, "%s invalid\n", type);
> break;
> - seq_puts(seq, "isolated invalid\n");
> - break;
> }
> return 0;
> }
> --
> 2.20.1.7.g153144c
>
--
tejun
prev parent reply other threads:[~2022-09-07 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 4:01 Jiapeng Chong
2022-09-07 15:32 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxi5gI1f2MxdC0c9@slm.duckdns.org \
--to=tj@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®