From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFD8C38145 for ; Wed, 7 Sep 2022 17:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbiIGRQo (ORCPT ); Wed, 7 Sep 2022 13:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbiIGRQm (ORCPT ); Wed, 7 Sep 2022 13:16:42 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4829BCCC2; Wed, 7 Sep 2022 10:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662571001; x=1694107001; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=FhbnyvCHPUalZVKZ0XsPpnzBkTOoT5SyRtycYuZjiVs=; b=HaclRdub2IVEbHOTupV0OrIOmWDiLOltbE4HlFsQ7k7RDHbvbrYV29r9 +8a6lpL1Mkb/EoA95lf4XFwLHfG17siJPQ/VxKMNc/PtDdLNBHxJSmHWm 0bZRENwStZKpoDsYdIs8d+Rx7n4jgzNb8O6yPQ6Y7DLqvHQfp82YGgyTq EoIcPLjRBhA+pHsupUWfc8LKDemJ+SxzSLqkjiNp2YPu7Aq/79K3t8fKI b7+hhq3yDs61cTvafqMeQz0fsn176Wwd/FcdPRrcHGz31qZqava9o4y7o Lej1RVmxqEf2wnQkK2qtAFUvkVpor8g3iK95QSc2DMT5U4SDckQ2UgY0J A==; X-IronPort-AV: E=McAfee;i="6500,9779,10463"; a="295678033" X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="295678033" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 10:16:29 -0700 X-IronPort-AV: E=Sophos;i="5.93,297,1654585200"; d="scan'208";a="565605191" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 10:16:27 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oVycx-009jZe-0p; Wed, 07 Sep 2022 20:14:15 +0300 Date: Wed, 7 Sep 2022 20:14:15 +0300 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Thierry Reding Subject: Re: [PATCH v1 2/9] pwm: lpss: Move exported symbols to PWM_LPSS namespace Message-ID: References: <20220906195735.87361-1-andriy.shevchenko@linux.intel.com> <20220906195735.87361-2-andriy.shevchenko@linux.intel.com> <20220907091144.picr3byckxco7w6m@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 07, 2022 at 08:00:42PM +0300, Andy Shevchenko wrote: > On Wed, Sep 07, 2022 at 05:21:53PM +0300, Andy Shevchenko wrote: > > On Wed, Sep 07, 2022 at 11:11:44AM +0200, Uwe Kleine-König wrote: > > > On Tue, Sep 06, 2022 at 10:57:28PM +0300, Andy Shevchenko wrote: ... > > > > -EXPORT_SYMBOL_GPL(pwm_lpss_probe); > > > > +EXPORT_SYMBOL_NS_GPL(pwm_lpss_probe, PWM_LPSS); > > > > > > There is something possible with more magic: > > > #define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS > > > > > > which you only need once in pwm-lpss.c and then all exports use that > > > namespace. (And if you pick up my suggestion for patch 1 you also > > > benefit from that.) > > > > For a single export (even for a few of them) it's an overkill. > > Ah, you adding there 4 more. But still I think it's an overkill. It's so small > driver that duplicating namespace in each of the exported symbols is not an > issue, is it? Okay, now looking at the patch organization (I forgot that I moved NS one to be not the first one) your suggestion makes a point. We won't change the code we just introduced. That said, I would like to get your SoB or what you agree with to the patch 1 and I make this one as you suggested. -- With Best Regards, Andy Shevchenko