mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: carsten.haitzler@foss.arm.com
Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	suzuki.poulose@arm.com, mathieu.poirier@linaro.org,
	mike.leach@linaro.org, linux-perf-users@vger.kernel.org,
	acme@kernel.org
Subject: Re: [PATCH v8 02/13] perf test: Add build infra for perf test tools for CoreSight tests
Date: Thu, 8 Sep 2022 20:44:11 +0800	[thread overview]
Message-ID: <Yxnjm7sA2Uit0X1M@leoy-huanghe.lan> (raw)
In-Reply-To: <20220906103044.761250-3-carsten.haitzler@foss.arm.com>

Hi Carsten,

On Tue, Sep 06, 2022 at 11:30:33AM +0100, carsten.haitzler@foss.arm.com wrote:

[...]

> --- /dev/null
> +++ b/tools/perf/tests/shell/coresight/Makefile
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
> +include ../../../../../tools/scripts/Makefile.include
> +include ../../../../../tools/scripts/Makefile.arch
> +include ../../../../../tools/scripts/utilities.mak
> +
> +SUBDIRS =
> +
> +all: $(SUBDIRS)
> +$(SUBDIRS):
> +	$(Q)$(MAKE) -C $@
> +
> +INSTALLDIRS = $(SUBDIRS:%=install-%)
> +
> +install-tests: $(INSTALLDIRS)
> +$(INSTALLDIRS):
> +	$(Q)$(MAKE) -C $(@:install-%=%) install-tests
> +
> +CLEANDIRS = $(SUBDIRS:%=clean-%)
> +
> +clean: $(CLEANDIRS)
> +$(CLEANDIRS):
> +	$(Q)$(MAKE) -C $(@:clean-%=%) clean >/dev/null
> +
> +.PHONY: all clean $(SUBDIRS) $(CLEANDIRS) $(INSTALLDIRS)
> +

I observed that git reports warning when applied this patch:

Applying: perf test: Add build infra for perf test tools for CoreSight tests
.git/rebase-apply/patch:107: new blank line at EOF.
+

The last blank line is redundant, it's good to drop it.  When you fix the
warning for rst doc file, you could fix this together.

P.s. at my side, git can automatically fix the redundant blink line
since I added "whitespace = fix" in my gitconfig.

Thanks,
Leo

  reply	other threads:[~2022-09-08 12:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 10:30 [PATCH v8 00/13] perf: test: Add trace data quality tests for CoreSight carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 01/13] perf test: Add CoreSight shell lib shared code for future tests carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 02/13] perf test: Add build infra for perf test tools for CoreSight tests carsten.haitzler
2022-09-08 12:44   ` Leo Yan [this message]
2022-09-06 10:30 ` [PATCH v8 03/13] perf test: Add asm pureloop test tool carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 04/13] perf test: Add asm pureloop test shell script carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 05/13] perf test: Add git ignore for perf data generated by the CoreSight tests carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 06/13] perf test: Add memcpy thread test tool carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 07/13] perf test: Add memcpy thread test shell script carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 08/13] perf test: Add thread loop test tool carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 09/13] perf test: Add thread loop test shell scripts carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 10/13] perf test: Add unroll thread test tool carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 11/13] perf test: Add unroll thread test shell script carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 12/13] perf test: Add git ignore for tmp and output files of CoreSight tests carsten.haitzler
2022-09-06 10:30 ` [PATCH v8 13/13] perf test: Add relevant documentation about CoreSight testing carsten.haitzler
2022-09-07  2:59   ` kernel test robot
2022-09-08 12:27     ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxnjm7sA2Uit0X1M@leoy-huanghe.lan \
    --to=leo.yan@linaro.org \
    --cc=acme@kernel.org \
    --cc=carsten.haitzler@foss.arm.com \
    --cc=coresight@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®