From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)
Date: Fri, 9 Sep 2022 11:42:01 +0300 [thread overview]
Message-ID: <Yxr8WYfRT+XKEKGK@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdYHWSc-kVUdr_YJ-YvMEc-LqrgDj0D62F2WKdA1H5Uvrw@mail.gmail.com>
On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Move the default values to the 'default' case in the switches.
> Patch applied!
Thanks!
...
> > case CY8C95X0_DRV_PP_SLOW:
> > case CY8C95X0_DRV_HIZ:
> > return true;
> > + default:
> > + return false;
> > }
> > -
> > - return false;
>
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?
The latter I believe. But I'm too busy and too lazy to go that road.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-09-09 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 14:21 Andy Shevchenko
2022-09-09 8:02 ` Linus Walleij
2022-09-09 8:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxr8WYfRT+XKEKGK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®