From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D93ECAAD3 for ; Fri, 9 Sep 2022 18:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229788AbiIISud (ORCPT ); Fri, 9 Sep 2022 14:50:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbiIISu3 (ORCPT ); Fri, 9 Sep 2022 14:50:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 088E189833 for ; Fri, 9 Sep 2022 11:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662749428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g9Dh8pEyMDv7C3f0d4E6QH8pWeVCfeTh7yGFQY5CPq0=; b=Fqd6B61sOZWbxHp4msUOigMh05IIMaSW5s6o88OASSpFtf9y9QC8+LCN4q4DJzwfGqR9Cl o6Vx33QG1MMXGW1rVSIR5F76H15ay+n7Q/L1ebQkWNT2QbmfSdNPWgVqJ5VlqLnD8XLOPu ZECZLw+PUmXGXhTfV9sORtG1niWgDOc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-S0jFSYMdNviySDb1ypgl6A-1; Fri, 09 Sep 2022 14:50:22 -0400 X-MC-Unique: S0jFSYMdNviySDb1ypgl6A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12242101A56C; Fri, 9 Sep 2022 18:50:22 +0000 (UTC) Received: from madcap2.tricolour.ca (unknown [10.22.48.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9BD452026D4C; Fri, 9 Sep 2022 18:50:20 +0000 (UTC) Date: Fri, 9 Sep 2022 14:50:18 -0400 From: Richard Guy Briggs To: Steve Grubb Cc: Jan Kara , Paul Moore , Linux-Audit Mailing List , LKML , linux-fsdevel@vger.kernel.org, Eric Paris , Amir Goldstein Subject: Re: [PATCH v4 3/4] fanotify,audit: Allow audit to use the full permission event response Message-ID: References: <4748798.GXAFRqVoOG@x2> <13104070.uLZWGnKmhe@x2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13104070.uLZWGnKmhe@x2> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-09-09 10:55, Steve Grubb wrote: > On Friday, September 9, 2022 10:38:46 AM EDT Richard Guy Briggs wrote: > > > Richard, add subj_trust and obj_trust. These can be 0|1|2 for no, yes, > > > unknown. > > > > type? bitfield? My gut would say that "0" should be "unset"/"unknown", > > but that is counterintuitive to the values represented. > > > > Or "trust" with sub-fields "subj" and "obj"? > > No. just make them separate and u32. subj_trust and obj_trust - no sub fields. > If we have sub-fields, that probably means bit mapping and that wasn't wanted. Ack. > -Steve - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635