mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "niklas.soderlund@corigine.com" <niklas.soderlund@corigine.com>
To: Joe Perches <joe@perches.com>
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
	"apw@canonical.com" <apw@canonical.com>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"louis.peens@corigine.com" <louis.peens@corigine.com>,
	"simon.horman@corigine.com" <simon.horman@corigine.com>,
	"oss-drivers@corigine.com" <oss-drivers@corigine.com>
Subject: Re: [PATCH v4] checkpatch: warn for non-standard fixes tag style
Date: Sat, 10 Sep 2022 10:48:58 +0200	[thread overview]
Message-ID: <YxxPepPX8Vp91XEA@oden.dyn.berto.se> (raw)
In-Reply-To: <9f9a0740aef282d30af8fa02ca7c6479e80aa9a0.camel@perches.com>

Hi Joe,

Thanks for your feedback.

On 2022-09-09 10:57:10 -0700, Joe Perches wrote:
> I think it's better to make sure that there is a likely SHA1 of some
> minimum length after the fixes line.
> 
> And a relatively common defect is to have the word "commit" after fixes.
> 
> e.g.:
> 
> Fixes commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver").
> Fixes commit a2c60d42d97c ("Add files for new driver - part 16").
> 
> So maybe:
> 
> 	if (!$in_header_lines &&
> 	    $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i)

I'm sorry I just sent out v6 and missed this comment, which I think is a 
great idea. I will let v6 stew for a day or two in case there is other 
feedback and then spin a v7 with this addressed.

-- 
Kind Regards,
Niklas Söderlund

  reply	other threads:[~2022-09-10  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 16:44 Niklas Söderlund
2022-09-08 17:49 ` Philippe Schenker
2022-09-09  7:40   ` niklas.soderlund
2022-09-09 14:39     ` Philippe Schenker
2022-09-09 17:57     ` Joe Perches
2022-09-10  8:48       ` niklas.soderlund [this message]
2022-09-11  2:47       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxxPepPX8Vp91XEA@oden.dyn.berto.se \
    --to=niklas.soderlund@corigine.com \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=lukas.bulwahn@gmail.com \
    --cc=oss-drivers@corigine.com \
    --cc=philippe.schenker@toradex.com \
    --cc=sfr@canb.auug.org.au \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®